Replace errorType return with Debug fail in checkExpressionWorker

[weswigham]

Per my suggestion and this comment.

[weswigham]

@typescript-bot test this
@typescript-bot run dt
@typescript-bot test top100
@typescript-bot perf test this

[typescript-bot]

Heya @weswigham, I've started to run the diff-based top-repos suite on this PR at 7dfe497. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @weswigham, I've started to run the extended test suite on this PR at 7dfe497. You can monitor the build here.

[typescript-bot]

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 7dfe497. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @weswigham, I've started to run the perf test suite on this PR at 7dfe497. You can monitor the build here.

Update: The results are in!

[typescript-bot]

@weswigham
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..54117

Metric	main	54117	Delta	Best	Worst	p-value
Angular - node (v18.10.0, x64)
Memory used	365,852k (± 0.01%)	365,887k (± 0.01%)	~	365,866k	365,912k	p=0.066 n=6
Parse Time	3.39s (± 0.66%)	3.41s (± 0.90%)	~	3.36s	3.44s	p=0.259 n=6
Bind Time	1.11s (± 0.73%)	1.11s (± 0.46%)	~	1.11s	1.12s	p=0.752 n=6
Check Time	8.73s (± 0.25%)	8.75s (± 0.66%)	~	8.68s	8.83s	p=0.807 n=6
Emit Time	7.44s (± 0.70%)	7.44s (± 0.65%)	~	7.39s	7.53s	p=0.935 n=6
Total Time	20.67s (± 0.28%)	20.71s (± 0.52%)	~	20.57s	20.89s	p=0.628 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used	190,960k (± 0.02%)	191,958k (± 1.20%)	~	190,951k	196,669k	p=0.065 n=6
Parse Time	1.49s (± 0.69%)	1.50s (± 0.70%)	~	1.49s	1.52s	p=0.098 n=6
Bind Time	0.77s (± 0.97%)	0.77s (± 1.05%)	~	0.76s	0.78s	p=0.729 n=6
Check Time	9.60s (± 0.33%)	9.64s (± 0.56%)	~	9.56s	9.71s	p=0.296 n=6
Emit Time	2.77s (± 1.19%)	2.77s (± 0.37%)	~	2.75s	2.78s	p=0.805 n=6
Total Time	14.64s (± 0.32%)	14.68s (± 0.35%)	~	14.62s	14.75s	p=0.199 n=6
Monaco - node (v18.10.0, x64)
Memory used	346,572k (± 0.01%)	346,564k (± 0.01%)	~	346,537k	346,594k	p=0.936 n=6
Parse Time	2.58s (± 0.41%)	2.58s (± 1.05%)	~	2.55s	2.62s	p=0.935 n=6
Bind Time	1.01s (± 1.15%)	1.00s (± 1.36%)	~	0.99s	1.02s	p=0.284 n=6
Check Time	7.18s (± 0.43%)	7.16s (± 0.30%)	~	7.13s	7.19s	p=0.629 n=6
Emit Time	4.28s (± 1.44%)	4.29s (± 0.74%)	~	4.25s	4.34s	p=0.630 n=6
Total Time	15.05s (± 0.55%)	15.03s (± 0.45%)	~	14.95s	15.12s	p=0.872 n=6
TFS - node (v18.10.0, x64)
Memory used	300,772k (± 0.01%)	300,750k (± 0.00%)	~	300,730k	300,765k	p=0.128 n=6
Parse Time	2.06s (± 1.37%)	2.05s (± 1.15%)	~	2.01s	2.08s	p=0.803 n=6
Bind Time	1.14s (± 0.72%)	1.14s (± 0.96%)	~	1.12s	1.15s	p=0.448 n=6
Check Time	6.61s (± 0.54%)	6.64s (± 0.57%)	~	6.57s	6.67s	p=0.226 n=6
Emit Time	3.90s (± 0.73%)	3.90s (± 0.94%)	~	3.85s	3.95s	p=0.936 n=6
Total Time	13.71s (± 0.29%)	13.73s (± 0.65%)	~	13.63s	13.85s	p=0.810 n=6
material-ui - node (v18.10.0, x64)
Memory used	482,306k (± 0.01%)	482,327k (± 0.01%)	~	482,269k	482,407k	p=0.689 n=6
Parse Time	3.10s (± 0.63%)	3.09s (± 0.72%)	~	3.05s	3.11s	p=0.933 n=6
Bind Time	0.90s (± 0.83%)	0.91s (± 1.08%)	~	0.90s	0.92s	p=0.109 n=6
Check Time	16.79s (± 0.35%)	16.86s (± 0.25%)	~	16.81s	16.93s	p=0.126 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	20.80s (± 0.26%)	20.86s (± 0.24%)	~	20.82s	20.96s	p=0.169 n=6
xstate - node (v18.10.0, x64)
Memory used	562,763k (± 0.02%)	562,838k (± 0.02%)	~	562,646k	562,975k	p=0.378 n=6
Parse Time	3.83s (± 0.53%)	3.83s (± 0.76%)	~	3.79s	3.87s	p=1.000 n=6
Bind Time	1.62s (± 0.91%)	1.63s (± 0.33%)	~	1.63s	1.64s	p=0.054 n=6
Check Time	2.81s (± 0.49%)	2.80s (± 0.67%)	~	2.78s	2.83s	p=0.371 n=6
Emit Time	0.08s (± 0.00%)	0.08s (± 0.00%)	~	0.08s	0.08s	p=1.000 n=6
Total Time	8.34s (± 0.29%)	8.36s (± 0.32%)	~	8.34s	8.41s	p=0.359 n=6
Angular - node (v16.17.1, x64)
Memory used	365,277k (± 0.01%)	365,280k (± 0.01%)	~	365,220k	365,321k	p=1.000 n=6
Parse Time	3.55s (± 0.31%)	3.54s (± 0.53%)	~	3.52s	3.57s	p=0.678 n=6
Bind Time	1.18s (± 0.54%)	1.18s (± 0.44%)	~	1.17s	1.18s	p=0.386 n=6
Check Time	9.59s (± 0.35%)	9.56s (± 0.55%)	~	9.48s	9.63s	p=0.421 n=6
Emit Time	7.89s (± 0.83%)	7.96s (± 0.69%)	+0.07s (+ 0.89%)	7.91s	8.06s	p=0.045 n=6
Total Time	22.21s (± 0.41%)	22.24s (± 0.45%)	~	22.09s	22.35s	p=0.575 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used	192,811k (± 0.03%)	192,745k (± 0.04%)	~	192,646k	192,832k	p=0.128 n=6
Parse Time	1.59s (± 1.59%)	1.58s (± 1.42%)	~	1.54s	1.60s	p=0.315 n=6
Bind Time	0.82s (± 0.63%)	0.82s (± 0.63%)	~	0.82s	0.83s	p=1.000 n=6
Check Time	10.35s (± 0.53%)	10.31s (± 0.39%)	~	10.26s	10.37s	p=0.199 n=6
Emit Time	3.01s (± 0.62%)	3.04s (± 0.32%)	~	3.02s	3.05s	p=0.059 n=6
Total Time	15.78s (± 0.43%)	15.76s (± 0.38%)	~	15.68s	15.85s	p=0.629 n=6
Monaco - node (v16.17.1, x64)
Memory used	345,861k (± 0.00%)	345,839k (± 0.01%)	~	345,809k	345,862k	p=0.078 n=6
Parse Time	2.72s (± 0.28%)	2.72s (± 0.38%)	~	2.71s	2.73s	p=0.348 n=6
Bind Time	1.08s (± 0.70%)	1.08s (± 0.48%)	~	1.08s	1.09s	p=0.784 n=6
Check Time	7.88s (± 0.60%)	7.87s (± 0.37%)	~	7.83s	7.91s	p=0.936 n=6
Emit Time	4.48s (± 0.67%)	4.50s (± 0.63%)	~	4.47s	4.54s	p=0.416 n=6
Total Time	16.17s (± 0.35%)	16.17s (± 0.27%)	~	16.12s	16.23s	p=0.936 n=6
TFS - node (v16.17.1, x64)
Memory used	300,110k (± 0.01%)	300,117k (± 0.01%)	~	300,095k	300,155k	p=0.688 n=6
Parse Time	2.15s (± 0.64%)	2.17s (± 0.58%)	+0.02s (+ 1.17%)	2.16s	2.19s	p=0.016 n=6
Bind Time	1.23s (± 0.98%)	1.25s (± 0.67%)	~	1.23s	1.25s	p=0.093 n=6
Check Time	7.29s (± 0.73%)	7.28s (± 0.39%)	~	7.23s	7.31s	p=0.935 n=6
Emit Time	4.41s (± 1.17%)	4.38s (± 0.62%)	~	4.35s	4.42s	p=0.569 n=6
Total Time	15.08s (± 0.72%)	15.07s (± 0.23%)	~	15.02s	15.11s	p=0.936 n=6
material-ui - node (v16.17.1, x64)
Memory used	481,561k (± 0.02%)	481,633k (± 0.01%)	~	481,606k	481,671k	p=0.066 n=6
Parse Time	3.24s (± 0.50%)	3.24s (± 0.16%)	~	3.24s	3.25s	p=0.451 n=6
Bind Time	0.93s (± 0.59%)	0.94s (± 0.86%)	~	0.94s	0.96s	p=0.054 n=6
Check Time	17.87s (± 0.44%)	17.88s (± 0.67%)	~	17.77s	18.09s	p=1.000 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	22.05s (± 0.38%)	22.07s (± 0.57%)	~	21.95s	22.30s	p=1.000 n=6
xstate - node (v16.17.1, x64)
Memory used	560,374k (± 0.01%)	560,481k (± 0.02%)	~	560,326k	560,617k	p=0.173 n=6
Parse Time	3.98s (± 0.30%)	4.00s (± 0.39%)	+0.02s (+ 0.59%)	3.97s	4.01s	p=0.035 n=6
Bind Time	1.76s (± 0.56%)	1.76s (± 0.56%)	~	1.75s	1.78s	p=1.000 n=6
Check Time	3.06s (± 0.64%)	3.06s (± 0.57%)	~	3.05s	3.09s	p=0.326 n=6
Emit Time	0.09s (± 4.62%)	0.09s (± 4.62%)	~	0.08s	0.09s	p=1.000 n=6
Total Time	8.88s (± 0.26%)	8.92s (± 0.18%)	+0.03s (+ 0.38%)	8.90s	8.94s	p=0.035 n=6
Angular - node (v14.21.3, x64)
Memory used	359,301k (± 0.00%)	359,286k (± 0.00%)	~	359,265k	359,304k	p=0.065 n=6
Parse Time	3.67s (± 0.72%)	3.67s (± 0.46%)	~	3.65s	3.69s	p=1.000 n=6
Bind Time	1.21s (± 0.45%)	1.21s (± 0.45%)	~	1.21s	1.22s	p=1.000 n=6
Check Time	9.99s (± 0.59%)	9.97s (± 0.20%)	~	9.95s	10.00s	p=0.747 n=6
Emit Time	8.28s (± 0.73%)	8.26s (± 0.63%)	~	8.21s	8.35s	p=0.334 n=6
Total Time	23.16s (± 0.50%)	23.12s (± 0.20%)	~	23.07s	23.20s	p=0.810 n=6
Compiler-Unions - node (v14.21.3, x64)
Memory used	188,096k (± 0.01%)	188,110k (± 0.01%)	~	188,069k	188,141k	p=0.378 n=6
Parse Time	1.61s (± 1.00%)	1.61s (± 0.78%)	~	1.60s	1.63s	p=1.000 n=6
Bind Time	0.84s (± 0.65%)	0.85s (± 1.43%)	~	0.85s	0.88s	p=0.054 n=6
Check Time	10.41s (± 0.45%)	10.49s (± 0.51%)	+0.08s (+ 0.82%)	10.43s	10.57s	p=0.030 n=6
Emit Time	3.17s (± 1.46%)	3.17s (± 1.30%)	~	3.11s	3.21s	p=0.687 n=6
Total Time	16.03s (± 0.49%)	16.13s (± 0.63%)	~	15.99s	16.26s	p=0.077 n=6
Monaco - node (v14.21.3, x64)
Memory used	340,956k (± 0.01%)	340,982k (± 0.01%)	~	340,935k	341,008k	p=0.149 n=6
Parse Time	2.80s (± 0.61%)	2.78s (± 0.20%)	~	2.78s	2.79s	p=0.100 n=6
Bind Time	1.11s (± 1.36%)	1.11s (± 0.88%)	~	1.10s	1.13s	p=0.801 n=6
Check Time	8.17s (± 0.49%)	8.15s (± 0.36%)	~	8.13s	8.21s	p=0.332 n=6
Emit Time	4.71s (± 0.86%)	4.72s (± 0.56%)	~	4.70s	4.76s	p=0.418 n=6
Total Time	16.79s (± 0.47%)	16.77s (± 0.36%)	~	16.73s	16.88s	p=0.808 n=6
TFS - node (v14.21.3, x64)
Memory used	295,291k (± 0.00%)	295,291k (± 0.00%)	~	295,284k	295,301k	p=1.000 n=6
Parse Time	2.39s (± 0.51%)	2.39s (± 0.77%)	~	2.36s	2.41s	p=1.000 n=6
Bind Time	1.07s (± 0.38%)	1.07s (± 0.84%)	~	1.06s	1.08s	p=0.787 n=6
Check Time	7.61s (± 0.50%)	7.59s (± 0.48%)	~	7.55s	7.64s	p=0.628 n=6
Emit Time	4.33s (± 1.04%)	4.35s (± 0.76%)	~	4.30s	4.39s	p=0.375 n=6
Total Time	15.39s (± 0.40%)	15.40s (± 0.34%)	~	15.31s	15.46s	p=1.000 n=6
material-ui - node (v14.21.3, x64)
Memory used	477,204k (± 0.00%)	477,184k (± 0.00%)	~	477,165k	477,210k	p=0.078 n=6
Parse Time	3.33s (± 0.62%)	3.32s (± 0.31%)	~	3.31s	3.34s	p=0.677 n=6
Bind Time	1.00s (± 0.75%)	1.00s (± 0.75%)	~	0.99s	1.01s	p=1.000 n=6
Check Time	18.80s (± 0.58%)	18.71s (± 0.29%)	~	18.65s	18.80s	p=0.078 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	23.12s (± 0.54%)	23.03s (± 0.28%)	~	22.95s	23.14s	p=0.149 n=6
xstate - node (v14.21.3, x64)
Memory used	549,324k (± 0.00%)	549,332k (± 0.00%)	~	549,300k	549,351k	p=0.261 n=6
Parse Time	4.19s (± 0.25%)	4.23s (± 1.10%)	+0.04s (+ 0.96%)	4.20s	4.32s	p=0.010 n=6
Bind Time	1.66s (± 1.84%)	1.63s (± 4.26%)	~	1.51s	1.68s	p=0.389 n=6
Check Time	3.17s (± 0.91%)	3.18s (± 0.65%)	~	3.14s	3.20s	p=0.519 n=6
Emit Time	0.09s (± 0.00%)	0.09s (± 4.45%)	~	0.09s	0.10s	p=0.405 n=6
Total Time	9.10s (± 0.37%)	9.13s (± 0.40%)	~	9.08s	9.16s	p=0.332 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-148-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v18.10.0, x64)
• node (v16.17.1, x64)
• node (v14.21.3, x64)

Scenarios

• Angular - node (v18.10.0, x64)
• Angular - node (v16.17.1, x64)
• Angular - node (v14.21.3, x64)
• Compiler-Unions - node (v18.10.0, x64)
• Compiler-Unions - node (v16.17.1, x64)
• Compiler-Unions - node (v14.21.3, x64)
• Monaco - node (v18.10.0, x64)
• Monaco - node (v16.17.1, x64)
• Monaco - node (v14.21.3, x64)
• TFS - node (v18.10.0, x64)
• TFS - node (v16.17.1, x64)
• TFS - node (v14.21.3, x64)
• material-ui - node (v18.10.0, x64)
• material-ui - node (v16.17.1, x64)
• material-ui - node (v14.21.3, x64)
• xstate - node (v18.10.0, x64)
• xstate - node (v16.17.1, x64)
• xstate - node (v14.21.3, x64)

Benchmark	Name	Iterations
Current	54117	6
Baseline	main	6

TSServer

Comparison Report - main..54117

Metric	main	54117	Delta	Best	Worst	p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	2,524ms (± 0.41%)	2,529ms (± 0.47%)	~	2,517ms	2,543ms	p=0.470 n=6
Req 2 - geterr	5,686ms (± 0.53%)	5,693ms (± 0.40%)	~	5,658ms	5,728ms	p=0.810 n=6
Req 3 - references	344ms (± 0.90%)	344ms (± 0.73%)	~	341ms	347ms	p=0.870 n=6
Req 4 - navto	282ms (± 0.91%)	284ms (± 1.06%)	~	280ms	289ms	p=0.292 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	85ms (± 0.96%)	85ms (± 0.65%)	~	84ms	85ms	p=0.088 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	2,625ms (± 0.58%)	2,647ms (± 1.05%)	~	2,596ms	2,672ms	p=0.109 n=6
Req 2 - geterr	4,337ms (± 0.46%)	4,324ms (± 1.67%)	~	4,181ms	4,379ms	p=0.689 n=6
Req 3 - references	348ms (± 0.67%)	349ms (± 0.38%)	~	347ms	351ms	p=0.323 n=6
Req 4 - navto	289ms (± 0.67%)	291ms (± 0.60%)	~	288ms	293ms	p=0.124 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	64ms (± 4.07%)	64ms (± 5.34%)	~	62ms	71ms	p=0.934 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	3,047ms (± 0.46%)	3,075ms (± 0.69%)	~	3,038ms	3,091ms	p=0.054 n=6
Req 2 - geterr	1,605ms (± 0.40%)	1,609ms (± 0.66%)	~	1,591ms	1,623ms	p=0.297 n=6
Req 3 - references	106ms (± 0.97%)	107ms (± 0.98%)	~	105ms	108ms	p=0.801 n=6
Req 4 - navto	362ms (± 0.14%)	363ms (± 0.14%)	+1ms (+ 0.28%)	362ms	363ms	p=0.018 n=6
Req 5 - completionInfo count	2,862 (± 0.00%)	2,862 (± 0.00%)	~	2,862	2,862	p=1.000 n=6
Req 5 - completionInfo	377ms (± 1.39%)	371ms (± 2.26%)	~	362ms	385ms	p=0.108 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	2,658ms (± 0.69%)	2,664ms (± 1.12%)	~	2,630ms	2,706ms	p=0.936 n=6
Req 2 - geterr	6,177ms (± 0.52%)	6,174ms (± 0.55%)	~	6,139ms	6,214ms	p=0.810 n=6
Req 3 - references	354ms (± 1.03%)	353ms (± 0.88%)	~	348ms	357ms	p=0.687 n=6
Req 4 - navto	284ms (± 1.48%)	284ms (± 0.82%)	~	280ms	287ms	p=0.678 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	86ms (± 5.82%)	83ms (± 3.75%)	~	80ms	87ms	p=0.288 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	2,808ms (± 0.64%)	2,814ms (± 0.36%)	~	2,799ms	2,823ms	p=0.630 n=6
Req 2 - geterr	4,717ms (± 0.59%)	4,713ms (± 0.49%)	~	4,693ms	4,744ms	p=0.689 n=6
Req 3 - references	364ms (± 0.71%)	364ms (± 0.55%)	~	361ms	366ms	p=0.681 n=6
Req 4 - navto	285ms (± 1.07%)	284ms (± 0.70%)	~	281ms	286ms	p=0.467 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	67ms (± 1.13%)	67ms (± 0.77%)	~	67ms	68ms	p=0.241 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	3,201ms (± 0.33%)	3,220ms (± 0.40%)	+19ms (+ 0.59%)	3,205ms	3,240ms	p=0.031 n=6
Req 2 - geterr	1,745ms (± 0.73%)	1,741ms (± 0.40%)	~	1,735ms	1,753ms	p=0.296 n=6
Req 3 - references	123ms (± 0.86%)	124ms (± 1.51%)	~	120ms	125ms	p=0.166 n=6
Req 4 - navto	341ms (± 0.60%)	342ms (± 0.68%)	~	339ms	345ms	p=0.808 n=6
Req 5 - completionInfo count	2,862 (± 0.00%)	2,862 (± 0.00%)	~	2,862	2,862	p=1.000 n=6
Req 5 - completionInfo	399ms (± 1.69%)	400ms (± 0.47%)	~	397ms	402ms	p=0.469 n=6
Compiler-UnionsTSServer - node (v14.21.3, x64)
Req 1 - updateOpen	2,770ms (± 0.41%)	2,790ms (± 0.55%)	+20ms (+ 0.72%)	2,775ms	2,812ms	p=0.031 n=6
Req 2 - geterr	6,345ms (± 0.73%)	6,361ms (± 0.76%)	~	6,277ms	6,418ms	p=0.575 n=6
Req 3 - references	364ms (± 0.33%)	365ms (± 0.77%)	~	360ms	368ms	p=0.373 n=6
Req 4 - navto	290ms (± 0.72%)	291ms (± 0.52%)	~	288ms	292ms	p=0.330 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	99ms (± 8.78%)	97ms (± 3.93%)	~	92ms	101ms	p=0.170 n=6
CompilerTSServer - node (v14.21.3, x64)
Req 1 - updateOpen	2,956ms (± 0.36%)	2,953ms (± 0.32%)	~	2,945ms	2,967ms	p=0.470 n=6
Req 2 - geterr	4,555ms (± 0.37%)	4,580ms (± 0.55%)	~	4,542ms	4,614ms	p=0.066 n=6
Req 3 - references	378ms (± 0.55%)	377ms (± 0.72%)	~	374ms	382ms	p=0.807 n=6
Req 4 - navto	298ms (± 0.35%)	298ms (± 0.49%)	~	296ms	300ms	p=1.000 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	77ms (± 0.67%)	76ms (± 0.99%)	~	75ms	77ms	p=0.247 n=6
xstateTSServer - node (v14.21.3, x64)
Req 1 - updateOpen	3,478ms (± 0.49%)	3,480ms (± 1.55%)	~	3,408ms	3,543ms	p=0.378 n=6
Req 2 - geterr	1,847ms (± 0.57%)	1,840ms (± 0.63%)	~	1,822ms	1,852ms	p=0.687 n=6
Req 3 - references	149ms (± 8.26%)	151ms (± 8.79%)	~	130ms	161ms	p=0.872 n=6
Req 4 - navto	398ms (± 1.78%)	393ms (± 1.41%)	~	386ms	400ms	p=0.377 n=6
Req 5 - completionInfo count	2,862 (± 0.00%)	2,862 (± 0.00%)	~	2,862	2,862	p=1.000 n=6
Req 5 - completionInfo	435ms (± 0.98%)	426ms (± 2.40%)	~	410ms	439ms	p=0.108 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-148-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v18.10.0, x64)
• node (v16.17.1, x64)
• node (v14.21.3, x64)

Scenarios

• Compiler-UnionsTSServer - node (v18.10.0, x64)
• Compiler-UnionsTSServer - node (v16.17.1, x64)
• Compiler-UnionsTSServer - node (v14.21.3, x64)
• CompilerTSServer - node (v18.10.0, x64)
• CompilerTSServer - node (v16.17.1, x64)
• CompilerTSServer - node (v14.21.3, x64)
• xstateTSServer - node (v18.10.0, x64)
• xstateTSServer - node (v16.17.1, x64)
• xstateTSServer - node (v14.21.3, x64)

Benchmark	Name	Iterations
Current	54117	6
Baseline	main	6

Startup

Comparison Report - main..54117

Metric	main	54117	Delta	Best	Worst	p-value
tsc-startup - node (v16.17.1, x64)
Execution time	141.48ms (± 0.22%)	141.35ms (± 0.20%)	-0.13ms (- 0.09%)	140.67ms	144.82ms	p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time	220.18ms (± 0.17%)	220.41ms (± 0.18%)	+0.23ms (+ 0.10%)	219.34ms	225.64ms	p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time	221.47ms (± 0.15%)	221.64ms (± 0.15%)	+0.17ms (+ 0.08%)	220.87ms	225.31ms	p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time	203.45ms (± 0.15%)	203.52ms (± 0.18%)	~	202.71ms	208.91ms	p=0.198 n=600

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-148-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v16.17.1, x64)

Scenarios

• tsc-startup - node (v16.17.1, x64)
• tsserver-startup - node (v16.17.1, x64)
• tsserverlibrary-startup - node (v16.17.1, x64)
• typescript-startup - node (v16.17.1, x64)

Benchmark	Name	Iterations
Current	54117	6
Baseline	main	6

Developer Information:

Download Benchmark

[typescript-bot]

Hey @weswigham, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

[typescript-bot]

@weswigham Here are the results of running the top-repos suite comparing main and refs/pull/54117/merge:

Everything looks good!

[weswigham]

@rbuckton should this be an expression? It's not flagged by isExpressionNode, but is definitely assigned to expression-expecting node positions.

[rbuckton]

We have two different ways to test for expressions, so we may need to verify both are correct:

• isExpression in utilitiesPublic.ts — Tests whether a Node is a subtype of Expression. Doesn't care about context (i.e., no .parent access). Designed for use with transformers (where .parent may not be set).
• isExpressionNode in _utilities.ts — Tests whether a Node is used in an expression position. Highly contextual (performs .parent lookups). Used by the checker, though I'd love to find a way to retire it at some point.

[sandersn]

@weswigham This looks like a strict improvement to me. Is there a reason not to merge this?