Replace errorType return with Debug fail in checkExpressionWorker

weswigham · weswigham · commit d7dabe800528 · 2023-05-03T11:10:44.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -37955,8 +37955,9 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                 return checkJsxAttributes(node as JsxAttributes, checkMode);
             case SyntaxKind.JsxOpeningElement:
                 Debug.fail("Shouldn't ever directly check a JsxOpeningElement");
+            default:
+                return Debug.failBadSyntaxKind(node, "Unhandled expression node kind in checkExpressionWorker");
         }
-        return errorType;
     }
 
     // DECLARATION AND STATEMENT TYPE CHECKING

Original file line number	Diff line number	Diff line change
`@@ -37955,8 +37955,9 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {`
`37955`	`37955`	`return checkJsxAttributes(node as JsxAttributes, checkMode);`
`37956`	`37956`	`case SyntaxKind.JsxOpeningElement:`
`37957`	`37957`	`Debug.fail("Shouldn't ever directly check a JsxOpeningElement");`
	`37958`	`+ default:`
	`37959`	`+ return Debug.failBadSyntaxKind(node, "Unhandled expression node kind in checkExpressionWorker");`
`37958`	`37960`	`}`
`37959`		`- return errorType;`
`37960`	`37961`	`}`
`37961`	`37962`
`37962`	`37963`	`// DECLARATION AND STATEMENT TYPE CHECKING`