Skip to content

Add missing ambient check to verbatimModuleSyntax export = error #53385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2023
Merged

Add missing ambient check to verbatimModuleSyntax export = error #53385

merged 2 commits into from
Mar 20, 2023

Conversation

@andrewbranch
Copy link
Member

@andrewbranch andrewbranch commented Mar 20, 2023

Fixes #53227

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Mar 20, 2023
@andrewbranch
Copy link
Member Author

andrewbranch commented Mar 20, 2023

@typescript-bot cherry-pick this to release-5.0

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 20, 2023 •
edited
Loading

Heya @andrewbranch, I've started to run the task to cherry-pick this into release-5.0 on this PR at 75187fb. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request Mar 20, 2023
Merged
@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 20, 2023

Hey @andrewbranch, I've opened #53389 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Mar 20, 2023
@andrewbranch @typescript-bot
Cherry-pick PR microsoft#53385 into release-5.0
35b7f2b 
Component commits:
d6c32ba Add missing ambient check to vMS export= error

75187fb Update older baseline
@andrewbranch andrewbranch merged commit af00915 into microsoft:main Mar 20, 2023
@andrewbranch andrewbranch deleted the bug/53227 branch March 20, 2023 19:05
@andrewbranch andrewbranch added this to the TypeScript 5.0.3 milestone Mar 20, 2023
DanielRosenwasser pushed a commit that referenced this pull request Mar 22, 2023
@andrewbranch
🤖 Pick PR #53385 (Add missing ambient check to `verba...) into releas…
5348903 
…e-5.0 (#53389)

Co-authored-by: Andrew Branch <[email protected]>
drivron pushed a commit to scenari/typescript that referenced this pull request Sep 14, 2023
@andrewbranch
🤖 Pick PR microsoft#53385 (Add missing ambient check to `verba...) in…
3fbfcfb 
…to release-5.0 (microsoft#53389)

Co-authored-by: Andrew Branch <[email protected]>
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakebailey jakebailey jakebailey approved these changes

Assignees

@andrewbranch andrewbranch

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Milestone

TypeScript 5.0.3

Development

Successfully merging this pull request may close these issues.

Should the 'verbatimModuleSyntax' check the d.ts file?

3 participants

@andrewbranch @typescript-bot @jakebailey