Remove old references to Node v4, small cleanup of node version stuff #53174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
jakebailey
commented
Mar 9, 2023
| @@ -1449,21 +1449,6 @@ declare const global: any; | |||
| declare const __filename: string; | |||
| declare const __dirname: string; | |||
|
|
|||
| export function getNodeMajorVersion(): number | undefined { | |||
There was a problem hiding this comment.
I could leave this, but, it's always going to be in the git history.
There was a problem hiding this comment.
Wow, this was public. Why?
There was a problem hiding this comment.
Consider cherry-picking to release-5.0?
There was a problem hiding this comment.
This whole PR? Or should I just make the function internal so it looks like it's going away?
RyanCavanaugh
approved these changes
Mar 9, 2023
sheetalkamat
approved these changes
Mar 9, 2023
|
@typescript-bot cherry-pick this to release-5.0 |
|
Heya @jakebailey, I'm starting to run the task to cherry-pick this into |
|
Hey @jakebailey, I've opened #53189 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Mar 9, 2023
DanielRosenwasser
pushed a commit
that referenced
this pull request
Mar 14, 2023
…e-5.0 (#53189) Co-authored-by: Jake Bailey <[email protected]>
drivron
pushed a commit
to scenari/typescript
that referenced
this pull request
Sep 14, 2023
…to release-5.0 (microsoft#53189) Co-authored-by: Jake Bailey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the places where we check if we're in Node 4 as we at a minimum realistically only support Node 10.
Also, remove a helper for parsing out the node version; it's only used for a debug log.