Fix debug assert for type assertions / JSX #52919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
sheetalkamat
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For vuejs/language-tools#2434
Plugins can have their own script kinds / extensions / variants, which means that
LanguageVariant.JSXandScriptKind.TSare not mutually exclusive.Just fix the assert to check the language variant, which is what we actually use to determine if a file should contain JSX elements (and therefore cannot contain old style type assertions).
I'd write a test for this, but, there don't appear to be any tests for external script kinds and this is supposed to be best-effort to prevent potential oddities / crashes in the checker anyway.