Fix type import node circularity errors in eager diagnostic mode, deprecations

[jakebailey]

Fixes #52570

Even though the name implies otherwise, a callback passed addLazyDiagnostic may be executed immediately if the checker is in eager mode.

The new code added in #51766 ended up causing a circularity error because in eager mode it was executed before links.resolvedType was set (which happens outside resolveImportSymbolType).

Fix this by effectively reverting #51766 and instead opting to reuse the existing code for type references. Reusing the existing code for this (instead of partially copying it) also has the benefit of fixing deprecated diagnostics which were broken for type import nodes (but I haven't been able to find anyone who reported such a thing yet).

[jakebailey]

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this

[typescript-bot]

Heya @jakebailey, I've started to run the extended test suite on this PR at 59ce29c. You can monitor the build here.

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 59ce29c. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based top-repos suite (tsserver) on this PR at 59ce29c. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 59ce29c. You can monitor the build here.

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 59ce29c. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based user code test suite (tsserver) on this PR at 59ce29c. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the perf test suite on this PR at 59ce29c. You can monitor the build here.

Update: The results are in!

[typescript-bot]

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/52861/merge:

Everything looks good!

[typescript-bot]

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/52861/merge:

Everything looks good!

[typescript-bot]

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/52861/merge:

Everything looks good!

[typescript-bot]

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/52861/merge:

Everything looks good!

[typescript-bot]

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52861

Metric	main	52861	Delta	Best	Worst	p-value
Angular - node (v18.10.0, x64)
Memory used	359,704k (± 0.01%)	359,690k (± 0.01%)	~	359,614k	359,731k	p=0.873 n=6
Parse Time	3.48s (± 0.42%)	3.48s (± 0.69%)	~	3.46s	3.52s	p=0.565 n=6
Bind Time	1.18s (± 0.44%)	1.18s (± 1.13%)	~	1.16s	1.20s	p=0.928 n=6
Check Time	8.74s (± 0.34%)	8.79s (± 0.46%)	~	8.74s	8.84s	p=0.075 n=6
Emit Time	7.57s (± 0.35%)	7.60s (± 0.62%)	~	7.57s	7.69s	p=0.414 n=6
Total Time	20.98s (± 0.13%)	21.05s (± 0.41%)	~	20.97s	21.20s	p=0.050 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used	190,904k (± 1.24%)	190,845k (± 1.20%)	~	189,837k	195,522k	p=0.575 n=6
Parse Time	1.48s (± 1.16%)	1.48s (± 0.70%)	~	1.47s	1.49s	p=0.675 n=6
Bind Time	0.79s (± 0.52%)	0.79s (± 0.65%)	~	0.79s	0.80s	p=0.595 n=6
Check Time	9.44s (± 0.61%)	9.37s (± 0.81%)	~	9.26s	9.44s	p=0.054 n=6
Emit Time	2.79s (± 0.67%)	2.81s (± 0.97%)	~	2.79s	2.86s	p=0.371 n=6
Total Time	14.51s (± 0.42%)	14.46s (± 0.46%)	~	14.35s	14.53s	p=0.295 n=6
Monaco - node (v18.10.0, x64)
Memory used	344,083k (± 0.01%)	344,056k (± 0.01%)	~	344,014k	344,115k	p=0.378 n=6
Parse Time	2.61s (± 1.07%)	2.64s (± 0.68%)	~	2.61s	2.66s	p=0.086 n=6
Bind Time	1.04s (± 1.32%)	1.05s (± 1.00%)	~	1.03s	1.06s	p=0.360 n=6
Check Time	7.13s (± 0.66%)	7.13s (± 0.46%)	~	7.09s	7.17s	p=0.872 n=6
Emit Time	4.32s (± 0.87%)	4.32s (± 0.63%)	~	4.28s	4.36s	p=1.000 n=6
Total Time	15.09s (± 0.34%)	15.13s (± 0.39%)	~	15.06s	15.21s	p=0.171 n=6
TFS - node (v18.10.0, x64)
Memory used	300,071k (± 0.01%)	300,074k (± 0.00%)	~	300,061k	300,083k	p=0.419 n=6
Parse Time	2.06s (± 0.73%)	2.07s (± 1.27%)	~	2.03s	2.10s	p=0.745 n=6
Bind Time	1.17s (± 0.35%)	1.18s (± 0.44%)	+0.01s (+ 0.71%)	1.17s	1.18s	p=0.022 n=6
Check Time	6.58s (± 0.65%)	6.57s (± 0.38%)	~	6.53s	6.60s	p=0.629 n=6
Emit Time	3.92s (± 0.73%)	3.91s (± 0.65%)	~	3.88s	3.95s	p=0.468 n=6
Total Time	13.73s (± 0.51%)	13.72s (± 0.21%)	~	13.68s	13.75s	p=0.422 n=6
material-ui - node (v18.10.0, x64)
Memory used	476,416k (± 0.00%)	476,416k (± 0.01%)	~	476,384k	476,453k	p=0.748 n=6
Parse Time	3.15s (± 0.99%)	3.16s (± 0.74%)	~	3.11s	3.17s	p=0.808 n=6
Bind Time	0.97s (± 0.42%)	0.97s (± 0.42%)	~	0.97s	0.98s	p=0.218 n=6
Check Time	17.25s (± 1.01%)	17.26s (± 0.20%)	~	17.22s	17.30s	p=0.261 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	21.37s (± 0.84%)	21.39s (± 0.18%)	~	21.34s	21.45s	p=0.296 n=6
xstate - node (v18.10.0, x64)
Memory used	548,605k (± 0.02%)	548,530k (± 0.03%)	~	548,329k	548,766k	p=0.173 n=6
Parse Time	4.08s (± 0.63%)	4.07s (± 0.64%)	~	4.04s	4.11s	p=0.571 n=6
Bind Time	1.74s (± 0.79%)	1.73s (± 1.34%)	~	1.69s	1.76s	p=0.511 n=6
Check Time	2.82s (± 0.43%)	2.82s (± 0.76%)	~	2.80s	2.85s	p=0.871 n=6
Emit Time	0.08s (± 0.00%)	0.08s (± 4.99%)	~	0.08s	0.09s	p=0.405 n=6
Total Time	8.72s (± 0.35%)	8.71s (± 0.49%)	~	8.64s	8.76s	p=1.000 n=6
Angular - node (v16.17.1, x64)
Memory used	359,025k (± 0.01%)	359,045k (± 0.01%)	~	359,029k	359,072k	p=0.173 n=6
Parse Time	3.72s (± 0.40%)	3.71s (± 0.22%)	~	3.70s	3.72s	p=0.271 n=6
Bind Time	1.23s (± 0.80%)	1.22s (± 0.68%)	~	1.22s	1.24s	p=0.588 n=6
Check Time	9.52s (± 0.38%)	9.54s (± 0.27%)	~	9.50s	9.57s	p=0.376 n=6
Emit Time	8.04s (± 0.36%)	8.04s (± 0.31%)	~	8.02s	8.09s	p=0.935 n=6
Total Time	22.50s (± 0.26%)	22.52s (± 0.13%)	~	22.47s	22.55s	p=0.872 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used	191,514k (± 0.03%)	191,538k (± 0.01%)	~	191,514k	191,557k	p=0.298 n=6
Parse Time	1.56s (± 0.81%)	1.55s (± 1.95%)	~	1.49s	1.57s	p=0.932 n=6
Bind Time	0.84s (± 0.48%)	0.84s (± 0.61%)	~	0.84s	0.85s	p=0.595 n=6
Check Time	10.08s (± 0.70%)	10.12s (± 0.56%)	~	10.05s	10.20s	p=0.261 n=6
Emit Time	3.05s (± 0.81%)	3.07s (± 0.56%)	~	3.05s	3.09s	p=0.145 n=6
Total Time	15.53s (± 0.54%)	15.58s (± 0.39%)	~	15.51s	15.68s	p=0.092 n=6
Monaco - node (v16.17.1, x64)
Memory used	343,338k (± 0.01%)	343,327k (± 0.01%)	~	343,285k	343,367k	p=0.575 n=6
Parse Time	2.79s (± 0.66%)	2.79s (± 0.62%)	~	2.77s	2.81s	p=1.000 n=6
Bind Time	1.11s (± 1.05%)	1.11s (± 0.46%)	~	1.11s	1.12s	p=0.666 n=6
Check Time	7.79s (± 0.55%)	7.79s (± 0.34%)	~	7.75s	7.82s	p=0.810 n=6
Emit Time	4.50s (± 0.70%)	4.50s (± 0.47%)	~	4.47s	4.52s	p=0.686 n=6
Total Time	16.19s (± 0.34%)	16.19s (± 0.21%)	~	16.16s	16.26s	p=0.686 n=6
TFS - node (v16.17.1, x64)
Memory used	299,415k (± 0.01%)	299,430k (± 0.01%)	~	299,403k	299,452k	p=0.149 n=6
Parse Time	2.19s (± 0.56%)	2.20s (± 0.55%)	~	2.18s	2.21s	p=0.182 n=6
Bind Time	1.26s (± 0.41%)	1.26s (± 0.87%)	~	1.25s	1.28s	p=0.784 n=6
Check Time	7.22s (± 0.19%)	7.23s (± 0.48%)	~	7.19s	7.27s	p=0.935 n=6
Emit Time	4.25s (± 0.88%)	4.25s (± 0.95%)	~	4.21s	4.32s	p=0.936 n=6
Total Time	14.91s (± 0.35%)	14.94s (± 0.54%)	~	14.86s	15.04s	p=0.687 n=6
material-ui - node (v16.17.1, x64)
Memory used	475,737k (± 0.01%)	475,680k (± 0.00%)	-57k (- 0.01%)	475,661k	475,708k	p=0.005 n=6
Parse Time	3.32s (± 0.44%)	3.33s (± 0.44%)	~	3.32s	3.35s	p=0.411 n=6
Bind Time	1.02s (± 0.40%)	1.02s (± 0.00%)	~	1.02s	1.02s	p=0.405 n=6
Check Time	18.21s (± 0.31%)	18.20s (± 0.25%)	~	18.15s	18.28s	p=0.520 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	22.55s (± 0.24%)	22.55s (± 0.19%)	~	22.49s	22.62s	p=1.000 n=6
xstate - node (v16.17.1, x64)
Memory used	546,144k (± 0.02%)	546,130k (± 0.03%)	~	545,971k	546,482k	p=0.689 n=6
Parse Time	4.25s (± 0.32%)	4.25s (± 0.40%)	~	4.23s	4.28s	p=0.864 n=6
Bind Time	1.81s (± 0.54%)	1.81s (± 0.70%)	~	1.79s	1.83s	p=1.000 n=6
Check Time	3.08s (± 0.81%)	3.06s (± 0.61%)	~	3.04s	3.09s	p=0.325 n=6
Emit Time	0.09s (± 0.00%)	0.09s (± 4.45%)	~	0.09s	0.10s	p=0.405 n=6
Total Time	9.23s (± 0.16%)	9.22s (± 0.24%)	~	9.19s	9.24s	p=0.360 n=6
Angular - node (v14.15.1, x64)
Memory used	352,568k (± 0.00%)	352,562k (± 0.00%)	~	352,548k	352,580k	p=0.748 n=6
Parse Time	3.71s (± 0.46%)	3.71s (± 0.44%)	~	3.69s	3.73s	p=0.871 n=6
Bind Time	1.29s (± 0.82%)	1.29s (± 0.63%)	~	1.28s	1.30s	p=0.865 n=6
Check Time	9.87s (± 0.30%)	9.86s (± 0.46%)	~	9.82s	9.95s	p=0.413 n=6
Emit Time	8.34s (± 0.74%)	8.38s (± 0.55%)	~	8.32s	8.44s	p=0.227 n=6
Total Time	23.21s (± 0.24%)	23.24s (± 0.23%)	~	23.16s	23.28s	p=0.288 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used	186,656k (± 0.01%)	186,695k (± 0.02%)	~	186,639k	186,725k	p=0.078 n=6
Parse Time	1.57s (± 0.57%)	1.58s (± 1.10%)	~	1.56s	1.61s	p=0.164 n=6
Bind Time	0.85s (± 0.98%)	0.86s (± 0.95%)	~	0.85s	0.87s	p=0.718 n=6
Check Time	10.24s (± 0.70%)	10.24s (± 1.24%)	~	10.10s	10.42s	p=0.936 n=6
Emit Time	3.14s (± 0.91%)	3.19s (± 1.03%)	~	3.14s	3.23s	p=0.060 n=6
Total Time	15.81s (± 0.51%)	15.87s (± 1.00%)	~	15.70s	16.11s	p=0.810 n=6
Monaco - node (v14.15.1, x64)
Memory used	338,189k (± 0.01%)	338,191k (± 0.01%)	~	338,153k	338,225k	p=0.873 n=6
Parse Time	2.89s (± 0.60%)	2.89s (± 0.55%)	~	2.86s	2.90s	p=0.737 n=6
Bind Time	1.12s (± 0.73%)	1.12s (± 0.67%)	~	1.11s	1.13s	p=0.306 n=6
Check Time	8.10s (± 0.42%)	8.11s (± 0.56%)	~	8.06s	8.17s	p=0.809 n=6
Emit Time	4.75s (± 0.26%)	4.78s (± 0.56%)	+0.03s (+ 0.60%)	4.75s	4.83s	p=0.035 n=6
Total Time	16.86s (± 0.14%)	16.91s (± 0.38%)	~	16.85s	17.01s	p=0.164 n=6
TFS - node (v14.15.1, x64)
Memory used	294,352k (± 0.01%)	294,323k (± 0.00%)	-28k (- 0.01%)	294,310k	294,349k	p=0.016 n=6
Parse Time	2.40s (± 0.90%)	2.38s (± 0.83%)	~	2.36s	2.41s	p=0.121 n=6
Bind Time	1.10s (± 1.21%)	1.09s (± 0.76%)	~	1.09s	1.11s	p=0.418 n=6
Check Time	7.55s (± 0.52%)	7.55s (± 0.35%)	~	7.50s	7.58s	p=0.936 n=6
Emit Time	4.61s (± 0.62%)	4.62s (± 0.65%)	~	4.59s	4.67s	p=0.327 n=6
Total Time	15.65s (± 0.37%)	15.63s (± 0.27%)	~	15.59s	15.71s	p=0.628 n=6
material-ui - node (v14.15.1, x64)
Memory used	471,231k (± 0.01%)	471,221k (± 0.00%)	~	471,202k	471,245k	p=0.470 n=6
Parse Time	3.49s (± 0.22%)	3.49s (± 0.68%)	~	3.46s	3.53s	p=0.620 n=6
Bind Time	1.04s (± 0.53%)	1.05s (± 1.32%)	~	1.03s	1.07s	p=0.138 n=6
Check Time	19.09s (± 0.19%)	19.16s (± 0.53%)	~	19.04s	19.27s	p=0.332 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	23.61s (± 0.15%)	23.69s (± 0.47%)	~	23.54s	23.80s	p=0.295 n=6
xstate - node (v14.15.1, x64)
Memory used	534,499k (± 0.00%)	534,510k (± 0.00%)	~	534,499k	534,526k	p=0.810 n=6
Parse Time	4.58s (± 0.43%)	4.58s (± 0.38%)	~	4.55s	4.60s	p=0.284 n=6
Bind Time	1.72s (± 0.30%)	1.72s (± 0.44%)	~	1.71s	1.73s	p=0.784 n=6
Check Time	3.16s (± 0.48%)	3.15s (± 0.55%)	~	3.13s	3.18s	p=0.373 n=6
Emit Time	0.10s (± 0.00%)	0.10s (± 5.21%)	~	0.10s	0.11s	p=0.071 n=6
Total Time	9.57s (± 0.09%)	9.56s (± 0.35%)	~	9.52s	9.60s	p=0.418 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v18.10.0, x64)
• node (v16.17.1, x64)
• node (v14.15.1, x64)

Scenarios

• Angular - node (v18.10.0, x64)
• Angular - node (v16.17.1, x64)
• Angular - node (v14.15.1, x64)
• Compiler-Unions - node (v18.10.0, x64)
• Compiler-Unions - node (v16.17.1, x64)
• Compiler-Unions - node (v14.15.1, x64)
• Monaco - node (v18.10.0, x64)
• Monaco - node (v16.17.1, x64)
• Monaco - node (v14.15.1, x64)
• TFS - node (v18.10.0, x64)
• TFS - node (v16.17.1, x64)
• TFS - node (v14.15.1, x64)
• material-ui - node (v18.10.0, x64)
• material-ui - node (v16.17.1, x64)
• material-ui - node (v14.15.1, x64)
• xstate - node (v18.10.0, x64)
• xstate - node (v16.17.1, x64)
• xstate - node (v14.15.1, x64)

Benchmark	Name	Iterations
Current	52861	6
Baseline	main	6

TSServer

Comparison Report - main..52861

Metric	main	52861	Delta	Best	Worst	p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	2,373ms (± 0.31%)	2,369ms (± 0.52%)	~	2,351ms	2,386ms	p=0.748 n=6
Req 2 - geterr	5,372ms (± 0.81%)	5,352ms (± 0.62%)	~	5,317ms	5,391ms	p=0.689 n=6
Req 3 - references	341ms (± 1.12%)	340ms (± 1.35%)	~	334ms	346ms	p=0.518 n=6
Req 4 - navto	282ms (± 0.82%)	280ms (± 0.49%)	~	279ms	282ms	p=0.164 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	72ms (± 1.44%)	71ms (± 1.45%)	~	70ms	73ms	p=0.560 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	2,491ms (± 0.68%)	2,528ms (± 1.39%)	~	2,478ms	2,571ms	p=0.092 n=6
Req 2 - geterr	4,044ms (± 0.81%)	4,039ms (± 0.58%)	~	4,006ms	4,074ms	p=0.810 n=6
Req 3 - references	353ms (± 0.50%)	349ms (± 0.76%)	-4ms (- 1.13%)	345ms	353ms	p=0.023 n=6
Req 4 - navto	288ms (± 0.36%)	289ms (± 1.04%)	~	284ms	293ms	p=0.416 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	71ms (± 9.43%)	67ms (± 0.94%)	~	66ms	68ms	p=0.070 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	3,189ms (± 0.90%)	3,217ms (± 0.62%)	+29ms (+ 0.89%)	3,195ms	3,253ms	p=0.045 n=6
Req 2 - geterr	1,645ms (± 0.93%)	1,652ms (± 0.78%)	~	1,640ms	1,675ms	p=0.630 n=6
Req 3 - references	104ms (± 1.78%)	103ms (± 1.37%)	~	101ms	105ms	p=0.255 n=6
Req 4 - navto	356ms (± 0.66%)	358ms (± 0.57%)	~	356ms	362ms	p=0.096 n=6
Req 5 - completionInfo count	3,136 (± 0.00%)	3,136 (± 0.00%)	~	3,136	3,136	p=1.000 n=6
Req 5 - completionInfo	427ms (± 1.32%)	431ms (± 0.76%)	~	424ms	433ms	p=0.468 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	2,525ms (± 0.80%)	2,527ms (± 1.04%)	~	2,476ms	2,546ms	p=0.575 n=6
Req 2 - geterr	5,755ms (± 0.40%)	5,750ms (± 0.38%)	~	5,719ms	5,782ms	p=0.689 n=6
Req 3 - references	351ms (± 0.58%)	352ms (± 0.87%)	~	347ms	356ms	p=0.466 n=6
Req 4 - navto	280ms (± 0.35%)	279ms (± 1.21%)	~	275ms	283ms	p=0.677 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	84ms (± 1.06%)	82ms (± 5.35%)	~	76ms	88ms	p=0.459 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	2,695ms (± 0.69%)	2,695ms (± 0.40%)	~	2,681ms	2,706ms	p=0.936 n=6
Req 2 - geterr	4,362ms (± 0.25%)	4,379ms (± 0.66%)	~	4,341ms	4,409ms	p=0.378 n=6
Req 3 - references	366ms (± 0.51%)	365ms (± 0.59%)	~	362ms	367ms	p=0.466 n=6
Req 4 - navto	281ms (± 0.42%)	283ms (± 1.50%)	~	279ms	288ms	p=0.746 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	74ms (± 0.85%)	73ms (± 1.03%)	~	72ms	74ms	p=0.081 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	3,362ms (± 0.26%)	3,372ms (± 0.37%)	~	3,360ms	3,394ms	p=0.297 n=6
Req 2 - geterr	1,873ms (± 4.29%)	1,820ms (± 0.54%)	~	1,809ms	1,830ms	p=0.229 n=6
Req 3 - references	112ms (± 1.56%)	112ms (± 1.77%)	~	109ms	115ms	p=0.492 n=6
Req 4 - navto	344ms (± 1.38%)	343ms (± 0.51%)	~	340ms	345ms	p=0.571 n=6
Req 5 - completionInfo count	3,136 (± 0.00%)	3,136 (± 0.00%)	~	3,136	3,136	p=1.000 n=6
Req 5 - completionInfo	434ms (± 1.35%)	435ms (± 0.94%)	~	429ms	439ms	p=1.000 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	2,608ms (± 1.08%)	2,615ms (± 0.56%)	~	2,590ms	2,628ms	p=0.575 n=6
Req 2 - geterr	6,099ms (± 1.02%)	6,063ms (± 0.38%)	~	6,021ms	6,091ms	p=0.229 n=6
Req 3 - references	366ms (± 1.03%)	364ms (± 0.64%)	~	361ms	368ms	p=0.568 n=6
Req 4 - navto	277ms (± 0.90%)	277ms (± 0.19%)	~	277ms	278ms	p=0.451 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	101ms (± 1.32%)	100ms (± 0.51%)	~	100ms	101ms	p=0.437 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	2,827ms (± 0.60%)	2,844ms (± 0.43%)	~	2,823ms	2,859ms	p=0.092 n=6
Req 2 - geterr	4,625ms (± 2.25%)	4,578ms (± 2.75%)	~	4,444ms	4,721ms	p=0.471 n=6
Req 3 - references	380ms (± 0.55%)	380ms (± 0.48%)	~	378ms	383ms	p=0.570 n=6
Req 4 - navto	293ms (± 1.25%)	293ms (± 1.17%)	~	289ms	296ms	p=1.000 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	85ms (± 9.64%)	86ms (± 9.41%)	~	81ms	102ms	p=0.805 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	3,680ms (± 0.38%)	3,689ms (± 0.72%)	~	3,651ms	3,718ms	p=0.748 n=6
Req 2 - geterr	1,866ms (± 1.98%)	1,855ms (± 1.43%)	~	1,823ms	1,893ms	p=0.575 n=6
Req 3 - references	127ms (± 3.05%)	127ms (± 4.40%)	~	121ms	137ms	p=0.872 n=6
Req 4 - navto	372ms (± 1.47%)	377ms (± 1.42%)	~	370ms	384ms	p=0.171 n=6
Req 5 - completionInfo count	3,136 (± 0.00%)	3,136 (± 0.00%)	~	3,136	3,136	p=1.000 n=6
Req 5 - completionInfo	450ms (± 1.72%)	448ms (± 1.27%)	~	440ms	457ms	p=1.000 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v18.10.0, x64)
• node (v16.17.1, x64)
• node (v14.15.1, x64)

Scenarios

• Compiler-UnionsTSServer - node (v18.10.0, x64)
• Compiler-UnionsTSServer - node (v16.17.1, x64)
• Compiler-UnionsTSServer - node (v14.15.1, x64)
• CompilerTSServer - node (v18.10.0, x64)
• CompilerTSServer - node (v16.17.1, x64)
• CompilerTSServer - node (v14.15.1, x64)
• xstateTSServer - node (v18.10.0, x64)
• xstateTSServer - node (v16.17.1, x64)
• xstateTSServer - node (v14.15.1, x64)

Benchmark	Name	Iterations
Current	52861	6
Baseline	main	6

Startup

Comparison Report - main..52861

Metric	main	52861	Delta	Best	Worst	p-value
tsc-startup - node (v16.17.1, x64)
Execution time	142.28ms (± 0.20%)	142.43ms (± 0.19%)	+0.15ms (+ 0.11%)	141.78ms	146.18ms	p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time	226.67ms (± 0.18%)	227.35ms (± 0.24%)	+0.68ms (+ 0.30%)	226.01ms	234.40ms	p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time	228.46ms (± 0.18%)	228.93ms (± 0.24%)	+0.46ms (+ 0.20%)	227.66ms	236.45ms	p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time	209.32ms (± 0.18%)	210.53ms (± 0.32%)	+1.21ms (+ 0.58%)	208.79ms	218.47ms	p=0.000 n=600

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v16.17.1, x64)

Scenarios

• tsc-startup - node (v16.17.1, x64)
• tsserver-startup - node (v16.17.1, x64)
• tsserverlibrary-startup - node (v16.17.1, x64)
• typescript-startup - node (v16.17.1, x64)

Benchmark	Name	Iterations
Current	52861	6
Baseline	main	6

Developer Information:

Download Benchmark