Fix crash in extract type and generate get/set refactors #52803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
jakebailey
reviewed
Feb 16, 2023
jakebailey
reviewed
Feb 16, 2023
src/compiler/utilities.ts
Outdated
| @@ -265,6 +266,7 @@ import { | |||
| isFunctionLike, | |||
| isFunctionLikeDeclaration, | |||
| isFunctionLikeOrClassStaticBlockDeclaration, | |||
| isFunctionTypeNode, | |||
Comment on lines
+266
to
+268
| (assignment as Mutable<PropertyAssignment>).modifiers = undefined; | ||
| (assignment as Mutable<PropertyAssignment>).questionToken = undefined; | ||
| (assignment as Mutable<PropertyAssignment>).exclamationToken = undefined; |
There was a problem hiding this comment.
Is this because update doesn't necessarily create a new node, but the result should still omit error recovery children?
There was a problem hiding this comment.
Yes, update only conditionally replaces the node.
DanielRosenwasser
approved these changes
Feb 16, 2023
jakebailey
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two crashes in refactors related to an attempt to refactor in the presence of a grammar error. This also removes
FunctionTypefrom the list of nodes that can have illegal modifiers, sinceisStartOfFunctionOrConstructorTypealready guards against a function type having modifiers.Fixes #52751