Skip to content

fix type checking of variables named "exports" #52209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2023
Merged

fix type checking of variables named "exports" #52209

merged 1 commit into from
Jan 20, 2023

Conversation

Tobias-Scholz
Copy link
Contributor

Fixes #52197

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jan 12, 2023
@Tobias-Scholz Tobias-Scholz mentioned this pull request Jan 12, 2023
Closed
@Tobias-Scholz Tobias-Scholz marked this pull request as ready for review January 12, 2023 18:37
sandersn
sandersn approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought there would be some JS tests that failed with that exemption removed, but looks like not. Let's ship this in the 5.0 beta.

@sandersn sandersn merged commit e01ced0 into microsoft:main Jan 20, 2023
@Tobias-Scholz Tobias-Scholz deleted the fix/52197 branch January 20, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

Assignees
No one assigned
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Variable named exports is not type-checked
3 participants
@Tobias-Scholz @sandersn @typescript-bot