Completely remove Push type #52133
Merged
Completely remove Push type #52133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
sandersn
approved these changes
Jan 19, 2023
|
@jakebailey I'm going through all the ready-to-merge PRs, and this one has been sitting for a while. I'd say let's merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #52122 I said I didn't have any immediate plan to attempt to remove it, but, it turns out that nearly all cases we use
Push, we only ever pass in an array. The only exception to that rule isnoopPush, where its only use can instead just bearray?.push(...)(and I sort of expect that to be more efficient than actually going to the effort of calling a noop function through an object).Whether or not this is desirable is another question; I can understand wanting to constrain uses to a specific operation, but I also like the cleanliness and consistency of just using arrays everywhere.