Skip to content

Conversation

@jakebailey
Copy link
Member

After merging #51565, I went to merge it into SFT only to hit issues with auto-imports; it looks like auto-imports always inserts new imports at the bottom unless the imports are sorted case-insensitivly.

Flipping these imports to case insensitive means that future auto-imports seem to be inserted in the right place.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 17, 2022
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should file 2 bugs:

  1. To fix auto imports insertion order on case-sensitive import lists
  2. To swap our imports back once we've shipped said fix

@jakebailey
Copy link
Member Author

How much do we need 2? My only problem is just that it's more churn for other PRs again if I reorder everything. I suppose it's one time, but I don't know that it actually matters what the order is as long as it merges well (which any sort will do).

@jakebailey jakebailey merged commit 00dc0b6 into microsoft:main Nov 17, 2022
@jakebailey jakebailey deleted the reformat-imports-2 branch November 17, 2022 23:42
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants