Removing some unnecessary methods from host and function parameters #51499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
approved these changes
Nov 14, 2022
|
I think its ok to break the API because its removal of methods that builder no longer needs so should be ok i think. Also havent found any usage that directly use this. |
|
Would you be able to document this in https://github.com/microsoft/TypeScript/wiki/API-Breaking-Changes ? If you need a review, we have https://github.com/microsoft/TypeScript-wiki |
andrewbranch
approved these changes
Nov 15, 2022
|
@DanielRosenwasser , so i just go ahead and add entry to 5.0 section after merging this PR.. correct? |
DanielRosenwasser
added
the
Breaking Change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.