Skip to content

Conform doc comments to TSDoc spec (experiment) #50736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"es6": true
},
"plugins": [
"@typescript-eslint", "jsdoc", "no-null", "import", "eslint-plugin-local"
"@typescript-eslint", "jsdoc", "no-null", "import", "eslint-plugin-local", "eslint-plugin-tsdoc"
],
"overrides": [
// By default, the ESLint CLI only looks at .js files. But, it will also look at
Expand All @@ -22,7 +22,13 @@
//
// ESLint in VS Code will lint any opened file (so long as it's not eslintignore'd), so
// that will work regardless of the below.
{ "files": ["*.ts", "*.mts", "*.cts", "*.mjs", "*.cjs"] }
{ "files": ["*.ts", "*.mts", "*.cts", "*.mjs", "*.cjs"] },
{
"files": ["*.js", "*.mjs", "*.cjs"],
"rules": {
"tsdoc/syntax": "off"
}
}
],
"rules": {
"@typescript-eslint/adjacent-overload-signatures": "error",
Expand Down Expand Up @@ -104,6 +110,9 @@

// eslint-plugin-jsdoc
"jsdoc/check-alignment": "error",

// eslint-plugin-tsdoc
"tsdoc/syntax": "error",

// eslint
"constructor-super": "error",
Expand Down
94 changes: 94 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@
"eslint-plugin-jsdoc": "^39.3.6",
"eslint-plugin-local": "^1.0.0",
"eslint-plugin-no-null": "^1.0.2",
"eslint-plugin-tsdoc": "^0.2.16",
"fancy-log": "latest",
"fs-extra": "^9.1.0",
"glob": "latest",
Expand Down
2 changes: 1 addition & 1 deletion scripts/buildProtocol.ts
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ function writeProtocolFile(outputFile: string, protocolTs: string, typeScriptSer

/**
* 1st pass - generate a program from protocol.ts and typescriptservices.d.ts and emit core version of protocol.d.ts with all internal members stripped
* @return text of protocol.d.t.s
* @returns text of protocol.d.t.s
*/
function getInitialDtsFileForProtocol() {
const program = ts.createProgram([protocolTs, typeScriptServicesDts, path.join(typeScriptServicesDts, "../lib.es5.d.ts")], options);
Expand Down
6 changes: 3 additions & 3 deletions src/compiler/binder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2996,7 +2996,7 @@ namespace ts {
}
}

/** For `x.prototype = { p, ... }`, declare members p,... if `x` is function/class/{}, or not declared. */
/** For `x.prototype = { p, ... }`, declare members p,... if `x` is function/class/`{}`, or not declared. */
function bindPrototypeAssignment(node: BindableStaticPropertyAssignmentExpression) {
setParent(node.left, node);
setParent(node.right, node);
Expand Down Expand Up @@ -3067,8 +3067,8 @@ namespace ts {
}

/**
* For nodes like `x.y = z`, declare a member 'y' on 'x' if x is a function (or IIFE) or class or {}, or not declared.
* Also works for expression statements preceded by JSDoc, like / ** @type number * / x.y;
* For nodes like `x.y = z`, declare a member 'y' on 'x' if x is a function (or IIFE) or class or `{}`, or not declared.
* Also works for expression statements preceded by JSDoc, like `/ ** @type number * / x.y`;
*/
function bindStaticPropertyAssignment(node: BindableStaticNameExpression) {
Debug.assert(!isIdentifier(node));
Expand Down
2 changes: 1 addition & 1 deletion src/compiler/builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -973,7 +973,7 @@ namespace ts {
}

/**
* @param optionKey key of CommandLineOption to use to determine if the option should be serialized in tsbuildinfo
* @param optionKey - key of CommandLineOption to use to determine if the option should be serialized in tsbuildinfo
*/
function convertToProgramBuildInfoCompilerOptions(options: CompilerOptions, optionKey: "affectsBundleEmitBuildInfo" | "affectsMultiFileEmitBuildInfo") {
let result: CompilerOptions | undefined;
Expand Down
Loading