Forward intersection state flag to conditional type target check #50620

andrewbranch · 2022-09-02T21:17:25Z

andrewbranch · 2022-09-02T21:18:06Z

@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot test top100
@typescript-bot perf test faster

typescript-bot · 2022-09-02T21:18:10Z

Heya @andrewbranch, I've started to run the diff-based user code test suite on this PR at 4635cdc. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-09-02T21:18:10Z

Heya @andrewbranch, I've started to run the diff-based user code test suite on this PR at 4635cdc. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-09-02T21:18:10Z

Heya @andrewbranch, I've started to run the abridged perf test suite on this PR at 4635cdc. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-09-02T21:18:10Z

Heya @andrewbranch, I've started to run the parallelized Definitely Typed test suite on this PR at 4635cdc. You can monitor the build here.

typescript-bot · 2022-09-02T21:30:20Z

@andrewbranch Here are the results of running the user test suite comparing main and refs/pull/50620/merge:

Everything looks good!

typescript-bot · 2022-09-02T21:37:47Z

@andrewbranch
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..50620

_Metric	_main	₅₀₆₂₀	_Delta	_Best	_Worst
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{338,729k (± 0.01%)}	_{338,737k (± 0.01%)}	_{+7k (+ 0.00%)}	_338,699k	_338,784k
_{Parse Time}	_{2.06s (± 0.60%)}	_{2.07s (± 0.70%)}	_{+0.01s (+ 0.44%)}	_2.04s	_2.10s
_{Bind Time}	_{0.79s (± 0.56%)}	_{0.79s (± 0.70%)}	_{0.00s ( 0.00%)}	_0.78s	_0.81s
_{Check Time}	_{5.84s (± 0.21%)}	_{5.83s (± 0.59%)}	_{-0.01s (- 0.26%)}	_5.76s	_5.93s
_{Emit Time}	_{6.15s (± 0.84%)}	_{6.16s (± 0.42%)}	_{+0.01s (+ 0.13%)}	_6.09s	_6.21s
_{Total Time}	_{14.84s (± 0.44%)}	_{14.85s (± 0.30%)}	_{+0.01s (+ 0.05%)}	_14.76s	_14.96s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{192,642k (± 0.03%)}	_{192,660k (± 0.01%)}	_{+18k (+ 0.01%)}	_192,610k	_192,692k
_{Parse Time}	_{0.85s (± 0.91%)}	_{0.85s (± 0.65%)}	_{+0.00s (+ 0.35%)}	_0.84s	_0.87s
_{Bind Time}	_{0.49s (± 1.03%)}	_{0.49s (± 0.75%)}	_{+0.00s (+ 0.21%)}	_0.48s	_0.49s
_{Check Time}	_{6.68s (± 0.57%)}	_{6.75s (± 0.59%)}	_{+0.06s (+ 0.96%)}	_6.66s	_6.83s
_{Emit Time}	_{2.41s (± 0.86%)}	_{2.47s (± 4.22%)}	_{+0.06s (+ 2.57%)}	_2.38s	_2.88s
_{Total Time}	_{10.43s (± 0.37%)}	_{10.56s (± 1.09%)}	_{+0.13s (+ 1.25%)}	_10.38s	_10.97s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{326,516k (± 0.01%)}	_{326,531k (± 0.01%)}	_{+15k (+ 0.00%)}	_326,475k	_326,579k
_{Parse Time}	_{1.57s (± 0.95%)}	_{1.57s (± 0.53%)}	_{+0.00s (+ 0.25%)}	_1.56s	_1.60s
_{Bind Time}	_{0.72s (± 0.51%)}	_{0.73s (± 1.19%)}	_{+0.00s (+ 0.41%)}	_0.71s	_0.75s
_{Check Time}	_{5.72s (± 0.65%)}	_{5.70s (± 0.37%)}	_{-0.02s (- 0.33%)}	_5.65s	_5.74s
_{Emit Time}	_{3.32s (± 0.72%)}	_{3.32s (± 0.60%)}	_{-0.00s (- 0.12%)}	_3.27s	_3.35s
_{Total Time}	_{11.33s (± 0.52%)}	_{11.32s (± 0.31%)}	_{-0.01s (- 0.12%)}	_11.25s	_11.40s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{289,656k (± 0.01%)}	_{289,661k (± 0.01%)}	_{+5k (+ 0.00%)}	_289,610k	_289,684k
_{Parse Time}	_{1.30s (± 0.47%)}	_{1.31s (± 0.71%)}	_{+0.01s (+ 1.00%)}	_1.30s	_1.33s
_{Bind Time}	_{0.79s (± 0.70%)}	_{0.80s (± 0.46%)}	_{+0.00s (+ 0.51%)}	_0.79s	_0.80s
_{Check Time}	_{5.36s (± 0.38%)}	_{5.37s (± 0.47%)}	_{+0.01s (+ 0.17%)}	_5.31s	_5.44s
_{Emit Time}	_{3.60s (± 0.82%)}	_{3.57s (± 0.65%)}	_{-0.03s (- 0.89%)}	_3.53s	_3.62s
_{Total Time}	_{11.05s (± 0.35%)}	_{11.04s (± 0.33%)}	_{-0.01s (- 0.11%)}	_10.95s	_11.10s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{436,458k (± 0.01%)}	_{436,331k (± 0.06%)}	_{-127k (- 0.03%)}	_435,269k	_436,525k
_{Parse Time}	_{1.86s (± 0.42%)}	_{1.86s (± 0.45%)}	_{-0.00s (- 0.00%)}	_1.84s	_1.88s
_{Bind Time}	_{0.58s (± 0.90%)}	_{0.58s (± 0.96%)}	_{-0.00s (- 0.17%)}	_0.57s	_0.59s
_{Check Time}	_{12.86s (± 1.02%)}	_{12.91s (± 0.94%)}	_{+0.04s (+ 0.32%)}	_12.70s	_13.24s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (±222.80%)}	_{🔻+0.00s (+ ∞%)}	_0.00s	_0.01s
_{Total Time}	_{15.31s (± 0.86%)}	_{15.35s (± 0.80%)}	_{+0.04s (+ 0.27%)}	_15.15s	_15.69s
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{546,727k (± 0.00%)}	_{546,723k (± 0.00%)}	_{-4k (- 0.00%)}	_546,685k	_546,756k
_{Parse Time}	_{2.59s (± 0.34%)}	_{2.59s (± 0.29%)}	_{-0.00s (- 0.12%)}	_2.57s	_2.61s
_{Bind Time}	_{0.97s (± 0.54%)}	_{0.97s (± 1.39%)}	_{0.00s ( 0.00%)}	_0.96s	_1.02s
_{Check Time}	_{1.52s (± 0.76%)}	_{1.52s (± 0.58%)}	_{-0.00s (- 0.07%)}	_1.51s	_1.54s
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 0.00%)}	_{0.00s ( 0.00%)}	_0.07s	_0.07s
_{Total Time}	_{5.16s (± 0.36%)}	_{5.16s (± 0.28%)}	_{+0.00s (+ 0.02%)}	_5.13s	_5.19s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-210-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v14.15.1, x64)

Scenarios

Angular - node (v14.15.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₀₆₂₀	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

typescript-bot · 2022-09-02T22:49:56Z

@andrewbranch Here are the results of running the top-repos suite comparing main and refs/pull/50620/merge:

Everything looks good!

andrewbranch · 2022-09-07T00:59:52Z

@ahejlsberg look ok for 4.8.3?

andrewbranch · 2022-09-07T01:01:30Z

Same question for the #50621 cherry-pick (same problem, different call site, I guess)

andrewbranch · 2022-09-07T16:48:02Z

@typescript-bot pack this

typescript-bot · 2022-09-07T16:48:05Z

Heya @andrewbranch, I've started to run the tarball bundle task on this PR at 4635cdc. You can monitor the build here.

andrewbranch · 2022-09-07T17:02:17Z

@typescript-bot cherry-pick to release-4.8

typescript-bot · 2022-09-07T17:02:19Z

Heya @andrewbranch, I've started to run the task to cherry-pick this into release-4.8 on this PR at 4635cdc. You can monitor the build here.

typescript-bot · 2022-09-07T17:07:54Z

Hey @andrewbranch, I've opened #50676 for you.

typescript-bot · 2022-09-07T17:09:13Z

Hey @andrewbranch, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/133667/artifacts?artifactName=tgz&fileId=09AF2876D7372115C09E6DCAE8350846F3EBCBEF60B29CDC804C42F4154A0E2102&fileName=/typescript-4.9.0-insiders.20220907.tgz"
    }
}

and then running npm install.

CryptoUnchained

Seems right to me

Forward intersection state flag to conditional type target check

4635cdc

typescript-bot assigned andrewbranch Sep 2, 2022

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Sep 2, 2022

andrewbranch requested a review from ahejlsberg September 2, 2022 21:17

andrewbranch added this to the TypeScript 4.8.3 milestone Sep 2, 2022

typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Sep 2, 2022

andrewbranch requested a review from weswigham September 7, 2022 15:35

weswigham approved these changes Sep 7, 2022

View reviewed changes

andrewbranch merged commit bb6f36f into microsoft:main Sep 7, 2022

andrewbranch deleted the bug/50619 branch September 7, 2022 17:07

typescript-bot mentioned this pull request Sep 7, 2022

🤖 Pick PR #50620 (Forward intersection state flag to ...) into release-4.8 #50676

Merged

CryptoUnchained reviewed Sep 9, 2022

View reviewed changes

sync-by-unito bot mentioned this pull request Sep 13, 2022

build(deps-dev): bump typescript from 4.6.4 to 4.8.3 numbersprotocol/capture-lite#2065

Closed

sync-by-unito bot mentioned this pull request Oct 1, 2022

build(deps-dev): bump typescript from 4.6.4 to 4.8.4 numbersprotocol/capture-lite#2134

Closed

sync-by-unito bot mentioned this pull request Oct 24, 2022

build(deps-dev): bump typescript from 4.7.4 to 4.8.4 SmartTokenLabs/token-negotiator#432

Closed

Forward intersection state flag to conditional type target check #50620

Forward intersection state flag to conditional type target check #50620

Uh oh!

Conversation

andrewbranch commented Sep 2, 2022

Uh oh!

andrewbranch commented Sep 2, 2022

Uh oh!

typescript-bot commented Sep 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 2, 2022

Uh oh!

typescript-bot commented Sep 2, 2022

Uh oh!

typescript-bot commented Sep 2, 2022

Uh oh!

andrewbranch commented Sep 7, 2022

Uh oh!

andrewbranch commented Sep 7, 2022

Uh oh!

andrewbranch commented Sep 7, 2022

Uh oh!

typescript-bot commented Sep 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrewbranch commented Sep 7, 2022

Uh oh!

typescript-bot commented Sep 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 7, 2022

Uh oh!

typescript-bot commented Sep 7, 2022

Uh oh!

CryptoUnchained left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

typescript-bot commented Sep 2, 2022 •

edited

Loading

typescript-bot commented Sep 2, 2022 •

edited

Loading

typescript-bot commented Sep 2, 2022 •

edited

Loading

typescript-bot commented Sep 2, 2022 •

edited

Loading

typescript-bot commented Sep 7, 2022 •

edited

Loading

typescript-bot commented Sep 7, 2022 •

edited

Loading