Skip to content

fix(49426): Object method snippet completions incorrectly add this parameters #49757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 5, 2022
Merged

fix(49426): Object method snippet completions incorrectly add this parameters #49757

merged 3 commits into from
Jul 5, 2022

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #49426

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Jul 1, 2022
gabritto
gabritto requested changes Jul 4, 2022
View reviewed changes
Copy link
Member

@gabritto gabritto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment on adding an equivalent type flag, but the rest looks good. I'll also try to get someone else to review it to make sure we're ok with adding a new NodeBuilderFlag.

@a-tarasyuk a-tarasyuk requested a review from gabritto July 5, 2022 07:02
gabritto
gabritto reviewed Jul 5, 2022
View reviewed changes
@gabritto gabritto requested review from weswigham and rbuckton July 5, 2022 17:21
@a-tarasyuk a-tarasyuk requested a review from gabritto July 5, 2022 18:02
@gabritto gabritto removed the request for review from rbuckton July 5, 2022 18:46
@gabritto gabritto merged commit cdc1996 into microsoft:main Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

@gabritto gabritto gabritto approved these changes

Assignees

@gabritto gabritto

Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Object method snippet completions incorrectly add this parameters
4 participants
@a-tarasyuk @weswigham @gabritto @typescript-bot