Object method snippet completions incorrectly add this parameters

[mjbvz]

Bug Report

🔎 Search Terms

• suggest / suggestions
• completions
• IntelliSense

🕗 Version & Regression Information

4.8.0-dev.20220606, not a regression

💻 Code

Try using a method snippet that uses a this parameter

interface IFoo {
    bar(this: IFoo): void; 
}

const foo: IFoo = {
    // Trigger completions here    
};

foo.bar();

🙁 Actual behavior

The this parameter is also inserted:

interface IFoo {
    bar(this: IFoo): void;
}

const foo: IFoo = {
    bar(this) {

    },
};

foo.bar();

🙂 Expected behavior

The this parameter should likely be omitted in this case

[gabritto]

Why should we omit the this parameter in this case?

[mjbvz]

@gabritto I originally hit this while working with some node apis. For example here I added destroy:

import { Transform } from "stream";

new Transform({
  destroy(this, error, callback) {

  },
})

The this parameter looks incorrect to me even though it isn't hurting anything. It would be clearer IMO to omit it

[RyanCavanaugh]

Honestly I was shocked that this parameters can get contextually typed; I thought this would be an implicit any. Anyway, it's not needed:

const foo: IFoo = {
    bar() {
        this.bar() // <- correctly typed
    },
};