Fix blocking of recursive dependencies in getNarrowedTypeOfSymbol #48941

ahejlsberg · 2022-05-03T18:13:19Z

andrewbranch

Thanks!

ahejlsberg · 2022-05-03T19:05:08Z

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster

typescript-bot · 2022-05-03T19:05:26Z

Heya @ahejlsberg, I've started to run the diff-based community code test suite on this PR at 56b4f68. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-05-03T19:05:26Z

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 56b4f68. You can monitor the build here.

typescript-bot · 2022-05-03T19:05:26Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 56b4f68. You can monitor the build here.

typescript-bot · 2022-05-03T19:05:26Z

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at 56b4f68. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-05-03T19:19:29Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..48941

_Metric	_main	₄₈₉₄₁	_Delta	_Best	_Worst
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{333,432k (± 0.01%)}	_{333,435k (± 0.01%)}	_{+3k (+ 0.00%)}	_333,381k	_333,471k
_{Parse Time}	_{2.02s (± 0.70%)}	_{2.03s (± 0.53%)}	_{+0.01s (+ 0.30%)}	_2.01s	_2.05s
_{Bind Time}	_{0.87s (± 0.77%)}	_{0.88s (± 0.56%)}	_{+0.00s (+ 0.34%)}	_0.86s	_0.88s
_{Check Time}	_{5.63s (± 0.37%)}	_{5.65s (± 0.36%)}	_{+0.02s (+ 0.28%)}	_5.60s	_5.70s
_{Emit Time}	_{6.31s (± 0.50%)}	_{6.36s (± 0.62%)}	_{+0.05s (+ 0.79%)}	_6.27s	_6.45s
_{Total Time}	_{14.84s (± 0.35%)}	_{14.92s (± 0.44%)}	_{+0.08s (+ 0.51%)}	_14.79s	_15.05s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{192,034k (± 0.13%)}	_{192,842k (± 0.51%)}	_{+808k (+ 0.42%)}	_192,055k	_195,530k
_{Parse Time}	_{0.86s (± 0.43%)}	_{0.85s (± 0.76%)}	_{-0.00s (- 0.47%)}	_0.84s	_0.86s
_{Bind Time}	_{0.56s (± 0.59%)}	_{0.56s (± 0.93%)}	_{+0.00s (+ 0.18%)}	_0.55s	_0.58s
_{Check Time}	_{7.48s (± 0.59%)}	_{7.49s (± 0.46%)}	_{+0.01s (+ 0.15%)}	_7.41s	_7.56s
_{Emit Time}	_{2.53s (± 1.21%)}	_{2.51s (± 0.88%)}	_{-0.01s (- 0.55%)}	_2.47s	_2.57s
_{Total Time}	_{11.43s (± 0.46%)}	_{11.42s (± 0.43%)}	_{-0.01s (- 0.08%)}	_11.33s	_11.52s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{325,505k (± 0.01%)}	_{325,478k (± 0.00%)}	_{-27k (- 0.01%)}	_325,454k	_325,534k
_{Parse Time}	_{1.57s (± 0.63%)}	_{1.58s (± 0.92%)}	_{+0.00s (+ 0.25%)}	_1.56s	_1.62s
_{Bind Time}	_{0.77s (± 0.47%)}	_{0.78s (± 0.63%)}	_{+0.00s (+ 0.26%)}	_0.77s	_0.79s
_{Check Time}	_{5.56s (± 0.53%)}	_{5.54s (± 0.41%)}	_{-0.02s (- 0.32%)}	_5.50s	_5.60s
_{Emit Time}	_{3.32s (± 0.55%)}	_{3.33s (± 0.68%)}	_{+0.01s (+ 0.33%)}	_3.29s	_3.40s
_{Total Time}	_{11.23s (± 0.40%)}	_{11.23s (± 0.48%)}	_{+0.00s (+ 0.01%)}	_11.13s	_11.40s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{289,078k (± 0.00%)}	_{289,064k (± 0.01%)}	_{-15k (- 0.01%)}	_288,995k	_289,106k
_{Parse Time}	_{1.37s (± 1.11%)}	_{1.36s (± 1.03%)}	_{-0.01s (- 0.44%)}	_1.34s	_1.41s
_{Bind Time}	_{0.72s (± 0.41%)}	_{0.73s (± 1.04%)}	_{+0.00s (+ 0.55%)}	_0.71s	_0.75s
_{Check Time}	_{5.20s (± 0.44%)}	_{5.20s (± 0.44%)}	_{+0.00s (+ 0.06%)}	_5.14s	_5.24s
_{Emit Time}	_{3.54s (± 1.76%)}	_{3.54s (± 2.25%)}	_{+0.01s (+ 0.20%)}	_3.39s	_3.70s
_{Total Time}	_{10.83s (± 0.75%)}	_{10.83s (± 0.88%)}	_{+0.00s (+ 0.02%)}	_10.64s	_11.00s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{447,804k (± 0.00%)}	_{447,829k (± 0.01%)}	_{+25k (+ 0.01%)}	_447,757k	_447,897k
_{Parse Time}	_{1.86s (± 0.62%)}	_{1.87s (± 0.46%)}	_{+0.00s (+ 0.16%)}	_1.84s	_1.88s
_{Bind Time}	_{0.70s (± 0.95%)}	_{0.70s (± 0.68%)}	_{-0.00s (- 0.43%)}	_0.69s	_0.71s
_{Check Time}	_{13.04s (± 0.57%)}	_{13.05s (± 0.81%)}	_{+0.01s (+ 0.09%)}	_12.90s	_13.29s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.60s (± 0.56%)}	_{15.61s (± 0.70%)}	_{+0.01s (+ 0.08%)}	_15.46s	_15.86s
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{535,910k (± 0.00%)}	_{535,005k (± 0.00%)}	_{-905k (- 0.17%)}	_534,953k	_535,060k
_{Parse Time}	_{2.59s (± 0.52%)}	_{2.59s (± 0.56%)}	_{-0.00s (- 0.15%)}	_2.55s	_2.61s
_{Bind Time}	_{1.14s (± 0.65%)}	_{1.14s (± 0.39%)}	_{-0.01s (- 0.44%)}	_1.13s	_1.15s
_{Check Time}	_{1.51s (± 0.38%)}	_{1.51s (± 0.44%)}	_{-0.00s (- 0.20%)}	_1.50s	_1.52s
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 6.19%)}	_{+0.00s (+ 2.86%)}	_0.07s	_0.09s
_{Total Time}	_{5.32s (± 0.22%)}	_{5.32s (± 0.31%)}	_{0.00s ( 0.00%)}	_5.27s	_5.35s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-210-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{2 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v14.15.1, x64)

Scenarios

Angular - node (v14.15.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₄₈₉₄₁	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

typescript-bot · 2022-05-03T19:24:38Z

@ahejlsberg
Great news! no new errors were found between main..refs/pull/48941/merge

DanielRosenwasser · 2022-05-03T19:31:27Z

@typescript-bot cherry-pick this to release-4.6

typescript-bot · 2022-05-03T19:31:30Z

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.6 on this PR at 56b4f68. You can monitor the build here.

typescript-bot · 2022-05-03T19:38:09Z

Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.6 manually.

DanielRosenwasser · 2022-05-03T19:50:44Z

Really? You couldn't cherry-pick a one-line change? 🙄

DanielRosenwasser · 2022-05-03T19:52:29Z

I'll cherry-pick the squash commit manually.

ahejlsberg · 2022-05-03T21:20:29Z

Tests and perf all look fine.

…8941) * Better blocking of recursive dependencies in getNarrowedTypeOfSymbol * Add regression test

…8941) (#48943) * Better blocking of recursive dependencies in getNarrowedTypeOfSymbol * Add regression test Co-authored-by: Anders Hejlsberg <[email protected]>

ahejlsberg added 2 commits May 3, 2022 11:00

Better blocking of recursive dependencies in getNarrowedTypeOfSymbol

2ce1eb9

Add regression test

56b4f68

typescript-bot assigned ahejlsberg May 3, 2022

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels May 3, 2022

ahejlsberg requested review from andrewbranch and DanielRosenwasser May 3, 2022 18:13

andrewbranch approved these changes May 3, 2022

View reviewed changes

ahejlsberg merged commit 38c1460 into main May 3, 2022

ahejlsberg deleted the fix48902 branch May 3, 2022 21:20

DanielRosenwasser pushed a commit that referenced this pull request May 3, 2022

Fix blocking of recursive dependencies in getNarrowedTypeOfSymbol (#4…

cd63882

…8941) * Better blocking of recursive dependencies in getNarrowedTypeOfSymbol * Add regression test

DanielRosenwasser mentioned this pull request May 3, 2022

[release-4.6] Cherry pick #48941 (get narrowed type of symbol fix) #48943

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix blocking of recursive dependencies in getNarrowedTypeOfSymbol #48941

Fix blocking of recursive dependencies in getNarrowedTypeOfSymbol #48941

ahejlsberg commented May 3, 2022

andrewbranch left a comment

ahejlsberg commented May 3, 2022

typescript-bot commented May 3, 2022 •

edited

Loading

typescript-bot commented May 3, 2022 •

edited

Loading

typescript-bot commented May 3, 2022 •

edited

Loading

typescript-bot commented May 3, 2022 •

edited

Loading

typescript-bot commented May 3, 2022

typescript-bot commented May 3, 2022

DanielRosenwasser commented May 3, 2022

typescript-bot commented May 3, 2022 •

edited

Loading

typescript-bot commented May 3, 2022

DanielRosenwasser commented May 3, 2022

DanielRosenwasser commented May 3, 2022

ahejlsberg commented May 3, 2022

Fix blocking of recursive dependencies in getNarrowedTypeOfSymbol #48941

Fix blocking of recursive dependencies in getNarrowedTypeOfSymbol #48941

Conversation

ahejlsberg commented May 3, 2022

andrewbranch left a comment

Choose a reason for hiding this comment

ahejlsberg commented May 3, 2022

typescript-bot commented May 3, 2022 • edited Loading

typescript-bot commented May 3, 2022 • edited Loading

typescript-bot commented May 3, 2022 • edited Loading

typescript-bot commented May 3, 2022 • edited Loading

typescript-bot commented May 3, 2022

typescript-bot commented May 3, 2022

DanielRosenwasser commented May 3, 2022

typescript-bot commented May 3, 2022 • edited Loading

typescript-bot commented May 3, 2022

DanielRosenwasser commented May 3, 2022

DanielRosenwasser commented May 3, 2022

ahejlsberg commented May 3, 2022

typescript-bot commented May 3, 2022 •

edited

Loading

typescript-bot commented May 3, 2022 •

edited

Loading

typescript-bot commented May 3, 2022 •

edited

Loading

typescript-bot commented May 3, 2022 •

edited

Loading

typescript-bot commented May 3, 2022 •

edited

Loading