fix(46824): remove duplicate private identifier errors #47116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46824
Description
Base on the suggestions in #46824, these two errors should not be reported if the private identifier is used inside a
for...in
For TS2304, an additional check is it also should not be reported if the private identifier is used with
in
operator.In the issue, @sandersn suggests
should only check for
in
operator andgetSymbolForPrivateIdentifierExpression
. But if I don't check for thefor...in
as well, it will show like thisTests
Failling tests: