-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Discourage typo fixes in PR template #46908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll green it, but IMO we should remove:
The same generally applies to other projects.
Because almost all advice for people getting started with OSS is to do this sort of change ( I've given that advice, and I'd give it again in the future ) as it's normally a cheap way to get used to the process
I like the spirit but feel the text is a bit strong. How about
|
Maybe a mash-up?
Go with Ryan's version unless he likes this one better. |
Edited to Ryan's version; I'll change it to Daniel's if desired. |
Wording taken from [this comment](microsoft#45834 (comment)). There have been a number of rejected typo fix PRs lately; hopefully this can reduce the amount of typo-fix-rejecting work for the team.
Removed "the same generally applies to other projects" per orta
Yeah, lets do this 👍🏻 |
Wording taken from this comment.
There have been a number of rejected typo fix PRs lately; hopefully this can reduce the amount of typo-fix-rejecting work for the team.