Fix typo #45834
Closed
Fix typo #45834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
|
Fixes #45879 |
|
It seems like you might have run a spell checker over some of our codebase, but didn't really read much about how our repo is structured, how to send a pull request, etc. We understand that typo fixes are generally nice, but these fixes don't help with code quality and add work to the core team. The same generally applies to other projects. To set a precedent, we won't be accepting this changeset. If you're interested in sending a PR, the issue tracker has many issues marked |
tjjfvi
added a commit
to tjjfvi/TypeScript
that referenced
this pull request
Nov 23, 2021
Wording taken from [this comment](microsoft#45834 (comment)). There have been a number of rejected typo fix PRs lately; hopefully this can reduce the amount of typo-fix-rejecting work for the team.
tjjfvi
added a commit
to tjjfvi/TypeScript
that referenced
this pull request
Dec 10, 2021
Wording taken from [this comment](microsoft#45834 (comment)). There have been a number of rejected typo fix PRs lately; hopefully this can reduce the amount of typo-fix-rejecting work for the team.
orta
pushed a commit
that referenced
this pull request
Dec 23, 2021
* Discourage typo fixes in PR template Wording taken from [this comment](#45834 (comment)). There have been a number of rejected typo fix PRs lately; hopefully this can reduce the amount of typo-fix-rejecting work for the team. * Tweak typo fix discouragement in PR template Removed "the same generally applies to other projects" per orta * Update typo fix discouragement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typo in subtypingWithGenericCallSignaturesWithOptionalParameters.ts:
instatiation -> instantiation