Bypass caching in removeStringLiteralsMatchedByTemplateLiterals #46525

ahejlsberg · 2021-10-25T22:25:09Z

ahejlsberg · 2021-10-25T23:02:16Z

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster

typescript-bot · 2021-10-25T23:02:19Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 6d84b02. You can monitor the build here.

typescript-bot · 2021-10-25T23:02:19Z

Heya @ahejlsberg, I've started to run the inline community code test suite on this PR at 6d84b02. You can monitor the build here.

Update: The results are in!

typescript-bot · 2021-10-25T23:02:20Z

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 6d84b02. You can monitor the build here.

typescript-bot · 2021-10-25T23:02:20Z

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at 6d84b02. You can monitor the build here.

Update: The results are in!

typescript-bot · 2021-10-25T23:17:31Z

@ahejlsberg
Great news! no new errors were found between main..refs/pull/46525/merge

typescript-bot · 2021-10-25T23:29:07Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..46525

_Metric	_main	₄₆₅₂₅	_Delta	_Best	_Worst
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{330,354k (± 0.01%)}	_{330,254k (± 0.06%)}	_{-100k (- 0.03%)}	_329,502k	_330,376k
_{Parse Time}	_{1.95s (± 0.64%)}	_{1.95s (± 0.87%)}	_{+0.00s (+ 0.21%)}	_1.93s	_2.01s
_{Bind Time}	_{0.86s (± 0.69%)}	_{0.86s (± 0.43%)}	_{-0.00s (- 0.12%)}	_0.85s	_0.86s
_{Check Time}	_{5.33s (± 0.43%)}	_{5.33s (± 0.41%)}	_{+0.00s (+ 0.09%)}	_5.30s	_5.39s
_{Emit Time}	_{6.13s (± 0.50%)}	_{6.14s (± 0.60%)}	_{+0.01s (+ 0.15%)}	_6.07s	_6.25s
_{Total Time}	_{14.26s (± 0.26%)}	_{14.27s (± 0.25%)}	_{+0.01s (+ 0.09%)}	_14.19s	_14.34s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{192,567k (± 0.49%)}	_{192,909k (± 0.36%)}	_{+342k (+ 0.18%)}	_190,078k	_193,285k
_{Parse Time}	_{0.81s (± 0.69%)}	_{0.81s (± 0.64%)}	_{+0.00s (+ 0.37%)}	_0.80s	_0.82s
_{Bind Time}	_{0.55s (± 0.40%)}	_{0.55s (± 0.40%)}	_{0.00s ( 0.00%)}	_0.55s	_0.56s
_{Check Time}	_{7.53s (± 0.44%)}	_{7.52s (± 0.41%)}	_{-0.01s (- 0.16%)}	_7.44s	_7.58s
_{Emit Time}	_{2.44s (± 0.71%)}	_{2.44s (± 0.93%)}	_{+0.00s (+ 0.08%)}	_2.41s	_2.52s
_{Total Time}	_{11.34s (± 0.42%)}	_{11.33s (± 0.34%)}	_{-0.01s (- 0.06%)}	_11.25s	_11.42s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{324,010k (± 0.01%)}	_{323,999k (± 0.00%)}	_{-10k (- 0.00%)}	_323,968k	_324,022k
_{Parse Time}	_{1.51s (± 0.62%)}	_{1.51s (± 0.70%)}	_{-0.00s (- 0.07%)}	_1.49s	_1.54s
_{Bind Time}	_{0.75s (± 0.48%)}	_{0.75s (± 0.59%)}	_{-0.00s (- 0.27%)}	_0.74s	_0.76s
_{Check Time}	_{5.30s (± 0.42%)}	_{5.28s (± 0.31%)}	_{-0.02s (- 0.34%)}	_5.24s	_5.31s
_{Emit Time}	_{3.20s (± 0.53%)}	_{3.21s (± 0.89%)}	_{+0.01s (+ 0.34%)}	_3.16s	_3.27s
_{Total Time}	_{10.76s (± 0.31%)}	_{10.75s (± 0.28%)}	_{-0.01s (- 0.11%)}	_10.66s	_10.81s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{288,365k (± 0.01%)}	_{288,364k (± 0.01%)}	_{-1k (- 0.00%)}	_288,324k	_288,392k
_{Parse Time}	_{1.23s (± 0.70%)}	_{1.22s (± 0.30%)}	_{-0.01s (- 0.65%)}	_1.22s	_1.23s
_{Bind Time}	_{0.73s (± 0.76%)}	_{0.73s (± 0.61%)}	_{-0.00s (- 0.55%)}	_0.72s	_0.74s
_{Check Time}	_{4.90s (± 0.53%)}	_{4.89s (± 0.42%)}	_{-0.01s (- 0.18%)}	_4.84s	_4.92s
_{Emit Time}	_{3.48s (± 0.69%)}	_{3.48s (± 0.62%)}	_{+0.01s (+ 0.17%)}	_3.44s	_3.53s
_{Total Time}	_{10.34s (± 0.35%)}	_{10.32s (± 0.32%)}	_{-0.02s (- 0.15%)}	_10.24s	_10.40s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{447,290k (± 0.08%)}	_{447,510k (± 0.00%)}	_{+220k (+ 0.05%)}	_447,434k	_447,537k
_{Parse Time}	_{1.82s (± 0.49%)}	_{1.83s (± 0.55%)}	_{+0.00s (+ 0.11%)}	_1.80s	_1.84s
_{Bind Time}	_{0.68s (± 0.54%)}	_{0.68s (± 0.54%)}	_{0.00s ( 0.00%)}	_0.67s	_0.68s
_{Check Time}	_{13.09s (± 0.97%)}	_{12.97s (± 0.48%)}	_{-0.12s (- 0.94%)}	_12.81s	_13.09s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.59s (± 0.84%)}	_{15.48s (± 0.41%)}	_{-0.12s (- 0.76%)}	_15.32s	_15.59s
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{533,836k (± 0.01%)}	_{533,828k (± 0.00%)}	_{-9k (- 0.00%)}	_533,775k	_533,874k
_{Parse Time}	_{2.55s (± 0.54%)}	_{2.55s (± 0.29%)}	_{-0.00s (- 0.04%)}	_2.54s	_2.57s
_{Bind Time}	_{1.15s (± 0.82%)}	_{1.15s (± 0.92%)}	_{-0.00s (- 0.26%)}	_1.12s	_1.17s
_{Check Time}	_{1.55s (± 0.54%)}	_{1.54s (± 0.38%)}	_{-0.00s (- 0.13%)}	_1.53s	_1.55s
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 0.00%)}	_{0.00s ( 0.00%)}	_0.07s	_0.07s
_{Total Time}	_{5.32s (± 0.36%)}	_{5.32s (± 0.34%)}	_{-0.00s (- 0.06%)}	_5.28s	_5.35s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-210-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{10 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v14.15.1, x64)

Scenarios

Angular - node (v14.15.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₄₆₅₂₅	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

ahejlsberg · 2021-10-26T14:20:29Z

Tests and performance look good.

…osoft#46525) * Bypass caching in removeStringLiteralsMatchedByTemplateLiterals * Add regression test

ahejlsberg added 2 commits October 24, 2021 07:29

Bypass caching in removeStringLiteralsMatchedByTemplateLiterals

0d343cb

Add regression test

6d84b02

typescript-bot assigned ahejlsberg Oct 25, 2021

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Oct 25, 2021

ahejlsberg requested a review from andrewbranch October 25, 2021 22:41

andrewbranch approved these changes Oct 26, 2021

View reviewed changes

ahejlsberg merged commit 658764e into main Oct 26, 2021

ahejlsberg deleted the fix46480 branch October 26, 2021 16:34

andrewbranch mentioned this pull request Oct 27, 2021

JavaScript heap out of memory with a string template literal type #45569

Closed

mprobst pushed a commit to mprobst/TypeScript that referenced this pull request Jan 10, 2022

Bypass caching in removeStringLiteralsMatchedByTemplateLiterals (micr…

d839ea7

…osoft#46525) * Bypass caching in removeStringLiteralsMatchedByTemplateLiterals * Add regression test

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bypass caching in removeStringLiteralsMatchedByTemplateLiterals #46525

Bypass caching in removeStringLiteralsMatchedByTemplateLiterals #46525

Uh oh!

ahejlsberg commented Oct 25, 2021

Uh oh!

ahejlsberg commented Oct 25, 2021

Uh oh!

typescript-bot commented Oct 25, 2021 •

edited

Loading

Uh oh!

typescript-bot commented Oct 25, 2021 •

edited

Loading

Uh oh!

typescript-bot commented Oct 25, 2021 •

edited

Loading

Uh oh!

typescript-bot commented Oct 25, 2021 •

edited

Loading

Uh oh!

typescript-bot commented Oct 25, 2021

Uh oh!

typescript-bot commented Oct 25, 2021

Uh oh!

ahejlsberg commented Oct 26, 2021

Uh oh!

Uh oh!

Bypass caching in removeStringLiteralsMatchedByTemplateLiterals #46525

Bypass caching in removeStringLiteralsMatchedByTemplateLiterals #46525

Uh oh!

Conversation

ahejlsberg commented Oct 25, 2021

Uh oh!

ahejlsberg commented Oct 25, 2021

Uh oh!

typescript-bot commented Oct 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 25, 2021

Uh oh!

typescript-bot commented Oct 25, 2021

Uh oh!

ahejlsberg commented Oct 26, 2021

Uh oh!

Uh oh!

typescript-bot commented Oct 25, 2021 •

edited

Loading

typescript-bot commented Oct 25, 2021 •

edited

Loading

typescript-bot commented Oct 25, 2021 •

edited

Loading

typescript-bot commented Oct 25, 2021 •

edited

Loading