When directory watcher is invoked with any file from node_modules package, invalidate for file paths in that package #43974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
DanielRosenwasser
approved these changes
May 6, 2021
Co-authored-by: Daniel Rosenwasser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because watch notifications are so unreliable, this is heuristic that will help with scenarios where we dont get notification for addition of index.d.ts for a package but some other files from it. This was the core issue in #41735 where it would eg get notification for
node_modules/@types/node/assert.d.tsand some such other files but not theindex.d.tsbutindex.d.tsis the main file that pulls the types so it would ignore the installation of@types/nodeand there would be error for not finding the types.Fixes #41735