Skip to content

Changes in node_modules not getting picked up in harness #41735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DanielRosenwasser opened this issue Nov 30, 2020 · 0 comments · Fixed by #43974
Closed

Changes in node_modules not getting picked up in harness #41735

DanielRosenwasser opened this issue Nov 30, 2020 · 0 comments · Fixed by #43974
Assignees
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue Rescheduled This issue was previously scheduled to an earlier milestone

Comments

@DanielRosenwasser
Copy link
Member

Open up src\testRunner\parallel\worker.ts

git checkout master
git reset 197ac804d164cdbc80876d49f87cbcf73a779c1c -- package.json
git reset 197ac804d164cdbc80876d49f87cbcf73a779c1c -- package-lock.json
npm ci

Now restart tsserver. You'll get an error about dispose not existing.

Then run

git checkout -- package.json
git checkout -- package-lock.json
npm ci

Now you'll see that Mocha isn't a found namespace anymore.

@DanielRosenwasser DanielRosenwasser added the Bug A bug in TypeScript label Nov 30, 2020
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 4.2.1 milestone Nov 30, 2020
@RyanCavanaugh RyanCavanaugh added the Rescheduled This issue was previously scheduled to an earlier milestone label Mar 4, 2021
sheetalkamat added a commit that referenced this issue May 6, 2021
…rom node_modules results in not refresing diagnostics

Test case for #41735
sheetalkamat added a commit that referenced this issue May 6, 2021
@typescript-bot typescript-bot added the Fix Available A PR has been opened for this issue label May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue Rescheduled This issue was previously scheduled to an earlier milestone
Projects
None yet
5 participants