Skip to content

Handle localness in special cases by checking exported variable assignment #43851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 30, 2021
Merged

Handle localness in special cases by checking exported variable assignment #43851

merged 4 commits into from
Apr 30, 2021

Conversation

sheetalkamat
Copy link
Member

Fixes #42976

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Apr 27, 2021
andrewbranch
andrewbranch approved these changes Apr 29, 2021
View reviewed changes
Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is the only place checker.isDeclarationVisible is used—seems like it could just be renamed to isDefinitionVisible and augmented with this code. Though, the distinction between the two is somewhat useful to understanding the code.

@sheetalkamat
Copy link
Member Author

isDeclarationVisible is introduced to be used by declaration emitter and hence keeping it distinct.

@sheetalkamat
Copy link
Member Author

Just noticed there are some test failures, i will take a look at them.

amcasey
amcasey reviewed Apr 29, 2021
View reviewed changes
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug mentions that file openness affects the behavior, but I don't see anything about that in this PR. Am I missing something?

@sheetalkamat
Copy link
Member Author

Depending on which project is open the set of things where it would be found is going to be different so its not relevant to this issue. The main issue is if project set would be opened based on localness (which was set to local before and now we try to make it not local) making it work.

amcasey
amcasey approved these changes Apr 29, 2021
View reviewed changes
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation!

sheetalkamat
sheetalkamat commented Apr 29, 2021
View reviewed changes
@sheetalkamat sheetalkamat merged commit c96b472 into master Apr 30, 2021
@sheetalkamat sheetalkamat deleted the findAllRefs branch April 30, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

+1 more reviewer

@amcasey amcasey amcasey approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@sheetalkamat sheetalkamat

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Typescript] Find All References does not find object properties in multi-module workspace
4 participants
@sheetalkamat @andrewbranch @amcasey @typescript-bot