Skip to content

Use last detected JSX import source pragma as canonical source, rather than first #43351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2021
Merged

Use last detected JSX import source pragma as canonical source, rather than first #43351

merged 1 commit into from
Mar 24, 2021

Conversation

weswigham
Copy link
Member

Thus aligning our preference with babel, which also takes the last found jsxImportSource pragma as the canonical one, rather than the first.

Fixes #43310

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 23, 2021
@weswigham weswigham mentioned this pull request Mar 23, 2021
Closed
@weswigham weswigham merged commit fb60c9f into microsoft:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

Assignees

@weswigham weswigham

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jsxImportSource is too eagerly parsed
3 participants
@weswigham @RyanCavanaugh @typescript-bot