IntelliSense doc string.replace typo #41385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
It looks like you've sent a pull request to update our 'lib' files. These files aren't meant to be edited by hand, as they consist of last-known good states of the compiler and are generated from 'src'. Unless this is necessary, consider closing the pull request and sending a separate PR to update 'src'. |
typescript-bot
added
lib update
This comment has been minimized.
This comment has been minimized.
sandersn
requested changes
Nov 18, 2020
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Some comments on wording. Also:
- Still need to revert lib change.
- The linter is complaining about formatting =(
typescript-bot
added
For Backlog Bug
sandersn
requested changes
Mar 10, 2021
orta
approved these changes
May 13, 2021
Contributor
orta
left a comment
orta
left a comment
There was a problem hiding this comment.
Kinda surprised this doesn't break baselines, but it looks good to me
sandersn
approved these changes
May 25, 2021
Member
|
@orta I think this change would only show up in a quickinfo baseline that explicitly tests |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
May 25, 2021
* Fix IntelliSense doc string.replace typo * Update IntelliSense doc string.replace * Update string.replace doc text * Revert "Fix IntelliSense doc string.replace typo" This reverts commit 4220ec8. * Reworded string.replace doc text * Fix doc string.replace text
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
May 25, 2021
* Fix IntelliSense doc string.replace typo * Update IntelliSense doc string.replace * Update string.replace doc text * Revert "Fix IntelliSense doc string.replace typo" This reverts commit 4220ec8. * Reworded string.replace doc text * Fix doc string.replace text
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
May 25, 2021
* Fix IntelliSense doc string.replace typo * Update IntelliSense doc string.replace * Update string.replace doc text * Revert "Fix IntelliSense doc string.replace typo" This reverts commit 4220ec8. * Reworded string.replace doc text * Fix doc string.replace text
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41361
As per https://www.w3schools.com/jsref/jsref_replace.asp
replace only replaces first value unless flags are used.