Skip to content

Stop doing tracing work when tracing is disabled #41261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2020
Merged

Stop doing tracing work when tracing is disabled #41261

merged 1 commit into from
Oct 27, 2020

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented Oct 27, 2020

By code inspection, the most likely reason #40634 regressed check time (and something we should fix even if it's not the root cause) is that push and pop were doing work even when tracing was disabled.

@amcasey amcasey requested a review from elibarzilay October 27, 2020 00:30
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 27, 2020
@amcasey amcasey requested a review from ahejlsberg October 27, 2020 00:30
@amcasey
Copy link
Member Author

amcasey commented Oct 27, 2020

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 27, 2020 •
edited
Loading

Heya @amcasey, I've started to run the perf test suite on this PR at e712d42. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@amcasey
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..41261

Metric master 41261 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 350,642k (± 0.03%) 350,545k (± 0.01%) -97k (- 0.03%) 350,454k 350,639k
Parse Time 2.10s (± 0.79%) 2.07s (± 0.36%) -0.03s (- 1.43%) 2.06s 2.09s
Bind Time 0.85s (± 2.36%) 0.84s (± 0.95%) -0.01s (- 1.53%) 0.82s 0.86s
Check Time 5.41s (± 0.59%) 4.97s (± 0.47%) 🟩-0.44s (- 8.13%) 4.92s 5.02s
Emit Time 5.35s (± 0.44%) 5.32s (± 0.46%) -0.03s (- 0.47%) 5.28s 5.38s
Total Time 13.71s (± 0.30%) 13.20s (± 0.33%) 🟩-0.51s (- 3.71%) 13.12s 13.30s
Monaco - node (v10.16.3, x64)
Memory used 354,659k (± 0.01%) 354,595k (± 0.02%) -64k (- 0.02%) 354,387k 354,722k
Parse Time 1.62s (± 0.66%) 1.60s (± 0.60%) -0.02s (- 1.24%) 1.58s 1.62s
Bind Time 0.72s (± 0.56%) 0.72s (± 0.81%) -0.00s (- 0.28%) 0.70s 0.73s
Check Time 5.57s (± 0.42%) 5.10s (± 0.41%) 🟩-0.47s (- 8.36%) 5.05s 5.14s
Emit Time 2.79s (± 0.55%) 2.77s (± 0.64%) -0.02s (- 0.75%) 2.73s 2.82s
Total Time 10.71s (± 0.36%) 10.19s (± 0.27%) 🟩-0.51s (- 4.79%) 10.14s 10.27s
TFS - node (v10.16.3, x64)
Memory used 307,939k (± 0.03%) 307,857k (± 0.01%) -82k (- 0.03%) 307,732k 307,921k
Parse Time 1.24s (± 0.67%) 1.23s (± 0.38%) -0.01s (- 0.49%) 1.22s 1.24s
Bind Time 0.68s (± 0.59%) 0.67s (± 0.99%) -0.01s (- 0.88%) 0.66s 0.69s
Check Time 5.08s (± 0.82%) 4.56s (± 0.47%) 🟩-0.53s (-10.35%) 4.51s 4.60s
Emit Time 2.89s (± 0.84%) 2.90s (± 0.99%) +0.01s (+ 0.28%) 2.84s 2.97s
Total Time 9.89s (± 0.32%) 9.36s (± 0.53%) 🟩-0.53s (- 5.38%) 9.25s 9.48s
material-ui - node (v10.16.3, x64)
Memory used 489,404k (± 0.01%) 489,216k (± 0.01%) -188k (- 0.04%) 489,111k 489,410k
Parse Time 2.08s (± 0.31%) 2.06s (± 0.19%) -0.02s (- 0.91%) 2.05s 2.07s
Bind Time 0.65s (± 1.04%) 0.65s (± 0.69%) -0.01s (- 0.92%) 0.64s 0.66s
Check Time 13.99s (± 0.52%) 13.49s (± 0.34%) 🟩-0.49s (- 3.52%) 13.41s 13.60s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.72s (± 0.43%) 16.20s (± 0.28%) 🟩-0.52s (- 3.09%) 16.13s 16.31s
Angular - node (v12.1.0, x64)
Memory used 327,904k (± 0.02%) 327,663k (± 0.07%) -241k (- 0.07%) 326,807k 327,870k
Parse Time 2.10s (± 0.90%) 2.06s (± 0.60%) -0.04s (- 1.72%) 2.04s 2.10s
Bind Time 0.82s (± 0.89%) 0.82s (± 1.92%) -0.00s (- 0.36%) 0.80s 0.88s
Check Time 5.37s (± 0.52%) 4.89s (± 0.39%) 🟩-0.47s (- 8.85%) 4.85s 4.94s
Emit Time 5.53s (± 0.99%) 5.52s (± 0.76%) -0.01s (- 0.22%) 5.45s 5.65s
Total Time 13.82s (± 0.56%) 13.30s (± 0.46%) 🟩-0.52s (- 3.80%) 13.20s 13.48s
Monaco - node (v12.1.0, x64)
Memory used 336,826k (± 0.02%) 336,652k (± 0.05%) -174k (- 0.05%) 335,997k 336,846k
Parse Time 1.60s (± 0.84%) 1.59s (± 0.66%) -0.01s (- 0.87%) 1.57s 1.62s
Bind Time 0.70s (± 0.98%) 0.70s (± 0.53%) -0.00s (- 0.14%) 0.69s 0.70s
Check Time 5.42s (± 0.56%) 4.92s (± 0.52%) 🟩-0.50s (- 9.27%) 4.86s 4.98s
Emit Time 2.86s (± 0.85%) 2.87s (± 0.71%) +0.00s (+ 0.07%) 2.83s 2.92s
Total Time 10.58s (± 0.39%) 10.07s (± 0.40%) 🟩-0.51s (- 4.85%) 9.97s 10.19s
TFS - node (v12.1.0, x64)
Memory used 292,195k (± 0.02%) 292,108k (± 0.02%) -87k (- 0.03%) 291,932k 292,221k
Parse Time 1.26s (± 0.56%) 1.25s (± 0.61%) -0.01s (- 0.48%) 1.24s 1.27s
Bind Time 0.65s (± 1.18%) 0.64s (± 0.74%) -0.00s (- 0.31%) 0.64s 0.66s
Check Time 5.02s (± 0.48%) 4.48s (± 0.40%) 🟩-0.54s (-10.75%) 4.45s 4.52s
Emit Time 2.96s (± 0.49%) 2.95s (± 1.04%) -0.00s (- 0.10%) 2.88s 3.02s
Total Time 9.89s (± 0.38%) 9.33s (± 0.39%) 🟩-0.55s (- 5.60%) 9.25s 9.40s
material-ui - node (v12.1.0, x64)
Memory used 467,187k (± 0.07%) 466,915k (± 0.09%) -272k (- 0.06%) 465,887k 467,399k
Parse Time 2.10s (± 0.66%) 2.07s (± 0.46%) -0.03s (- 1.62%) 2.04s 2.08s
Bind Time 0.65s (± 0.93%) 0.64s (± 0.75%) -0.01s (- 1.24%) 0.63s 0.65s
Check Time 12.59s (± 0.93%) 12.02s (± 0.79%) 🟩-0.57s (- 4.50%) 11.87s 12.25s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.34s (± 0.82%) 14.73s (± 0.61%) 🟩-0.61s (- 3.96%) 14.60s 14.96s
Angular - node (v8.9.0, x64)
Memory used 353,067k (± 0.01%) 353,008k (± 0.02%) -59k (- 0.02%) 352,891k 353,156k
Parse Time 2.66s (± 0.66%) 2.64s (± 0.25%) -0.02s (- 0.79%) 2.63s 2.66s
Bind Time 0.89s (± 0.68%) 0.87s (± 1.04%) -0.01s (- 1.58%) 0.85s 0.89s
Check Time 5.99s (± 0.72%) 5.57s (± 0.42%) 🟩-0.41s (- 6.92%) 5.52s 5.62s
Emit Time 6.31s (± 1.91%) 6.31s (± 0.94%) -0.00s (- 0.06%) 6.19s 6.45s
Total Time 15.85s (± 0.94%) 15.40s (± 0.51%) -0.45s (- 2.83%) 15.25s 15.61s
Monaco - node (v8.9.0, x64)
Memory used 358,493k (± 0.01%) 358,399k (± 0.02%) -94k (- 0.03%) 358,185k 358,521k
Parse Time 1.94s (± 0.27%) 1.93s (± 0.58%) -0.01s (- 0.41%) 1.92s 1.97s
Bind Time 0.90s (± 0.86%) 0.90s (± 0.68%) 0.00s ( 0.00%) 0.89s 0.91s
Check Time 6.14s (± 0.42%) 5.62s (± 0.43%) 🟩-0.52s (- 8.44%) 5.57s 5.66s
Emit Time 3.31s (± 0.48%) 3.37s (± 0.64%) +0.06s (+ 1.78%) 3.32s 3.42s
Total Time 12.29s (± 0.28%) 11.82s (± 0.31%) 🟩-0.47s (- 3.80%) 11.75s 11.93s
TFS - node (v8.9.0, x64)
Memory used 310,304k (± 0.02%) 310,240k (± 0.01%) -64k (- 0.02%) 310,163k 310,353k
Parse Time 1.57s (± 0.25%) 1.57s (± 0.65%) 0.00s ( 0.00%) 1.55s 1.60s
Bind Time 0.68s (± 0.73%) 0.68s (± 0.44%) -0.01s (- 1.02%) 0.67s 0.68s
Check Time 5.77s (± 0.69%) 5.30s (± 0.40%) 🟩-0.47s (- 8.16%) 5.27s 5.34s
Emit Time 2.97s (± 0.45%) 2.96s (± 1.00%) -0.01s (- 0.40%) 2.87s 3.01s
Total Time 11.00s (± 0.44%) 10.52s (± 0.37%) 🟩-0.49s (- 4.43%) 10.41s 10.59s
material-ui - node (v8.9.0, x64)
Memory used 496,241k (± 0.01%) 496,169k (± 0.01%) -73k (- 0.01%) 495,986k 496,336k
Parse Time 2.52s (± 0.50%) 2.50s (± 0.48%) -0.02s (- 0.87%) 2.46s 2.52s
Bind Time 0.81s (± 0.37%) 0.81s (± 0.86%) -0.00s (- 0.12%) 0.79s 0.82s
Check Time 18.25s (± 0.44%) 17.83s (± 0.73%) -0.42s (- 2.27%) 17.49s 18.07s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 21.58s (± 0.36%) 21.14s (± 0.64%) -0.44s (- 2.03%) 20.78s 21.38s
Angular - node (v8.9.0, x86)
Memory used 202,174k (± 0.01%) 202,026k (± 0.02%) -148k (- 0.07%) 201,940k 202,103k
Parse Time 2.57s (± 0.82%) 2.56s (± 0.86%) -0.01s (- 0.54%) 2.52s 2.61s
Bind Time 1.01s (± 0.99%) 1.01s (± 0.55%) -0.00s (- 0.20%) 1.00s 1.02s
Check Time 5.53s (± 0.59%) 5.07s (± 0.62%) 🟩-0.46s (- 8.27%) 5.02s 5.17s
Emit Time 6.09s (± 0.86%) 6.07s (± 0.70%) -0.02s (- 0.38%) 5.97s 6.16s
Total Time 15.20s (± 0.48%) 14.71s (± 0.47%) 🟩-0.49s (- 3.25%) 14.57s 14.85s
Monaco - node (v8.9.0, x86)
Memory used 203,002k (± 0.02%) 202,922k (± 0.02%) -80k (- 0.04%) 202,803k 203,022k
Parse Time 1.99s (± 0.62%) 1.99s (± 1.17%) -0.01s (- 0.30%) 1.95s 2.06s
Bind Time 0.71s (± 0.69%) 0.71s (± 0.31%) -0.00s (- 0.42%) 0.71s 0.72s
Check Time 6.23s (± 0.56%) 5.68s (± 1.95%) 🟩-0.56s (- 8.92%) 5.35s 5.82s
Emit Time 2.75s (± 0.36%) 2.81s (± 3.54%) +0.06s (+ 2.15%) 2.71s 3.10s
Total Time 11.69s (± 0.27%) 11.18s (± 0.40%) 🟩-0.50s (- 4.31%) 11.09s 11.28s
TFS - node (v8.9.0, x86)
Memory used 177,388k (± 0.02%) 177,378k (± 0.02%) -10k (- 0.01%) 177,270k 177,481k
Parse Time 1.62s (± 0.92%) 1.60s (± 1.21%) -0.01s (- 0.68%) 1.58s 1.67s
Bind Time 0.64s (± 0.53%) 0.65s (± 0.58%) +0.01s (+ 1.26%) 0.64s 0.65s
Check Time 5.36s (± 0.62%) 4.84s (± 0.65%) 🟩-0.52s (- 9.74%) 4.79s 4.94s
Emit Time 2.83s (± 1.08%) 2.83s (± 0.89%) +0.00s (+ 0.04%) 2.79s 2.91s
Total Time 10.44s (± 0.31%) 9.92s (± 0.59%) 🟩-0.52s (- 5.00%) 9.84s 10.11s
material-ui - node (v8.9.0, x86)
Memory used 279,286k (± 0.01%) 279,248k (± 0.01%) -38k (- 0.01%) 279,158k 279,332k
Parse Time 2.57s (± 0.56%) 2.55s (± 0.32%) -0.02s (- 0.66%) 2.53s 2.57s
Bind Time 0.76s (± 6.20%) 0.76s (± 7.97%) -0.00s (- 0.26%) 0.68s 0.89s
Check Time 16.82s (± 0.44%) 16.44s (± 1.07%) -0.38s (- 2.28%) 16.03s 16.81s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 20.15s (± 0.41%) 19.75s (± 0.86%) -0.40s (- 1.97%) 19.42s 20.05s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
Benchmark Name Iterations
Current 41261 10
Baseline master 10

@rbuckton
Copy link
Contributor

That's looking much better.

@amcasey amcasey merged commit 4518799 into microsoft:master Oct 27, 2020
@amcasey amcasey deleted the TracingPerf branch October 27, 2020 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbuckton rbuckton rbuckton approved these changes

@elibarzilay elibarzilay Awaiting requested review from elibarzilay

@ahejlsberg ahejlsberg Awaiting requested review from ahejlsberg

Assignees
No one assigned
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amcasey @typescript-bot @rbuckton