Skip to content

Conversation

weswigham
Copy link
Member

There was a special case in js declaration emit that was a bit overbroad in its condition.

Fixes #40859

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Oct 1, 2020
@andrewbranch
Copy link
Member

If you merge this in this cycle, don't forget to re-milestone the issue.

@weswigham weswigham merged commit da86332 into microsoft:master Oct 1, 2020
@weswigham weswigham deleted the js-declarations-export-objects branch October 1, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emitting declarations for commonjs exported classes suggests classes are private, TS9006
3 participants