Load ETW module from a specified path #39599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@typescript-bot cherry-pick this to release-3.9 |
|
Heya @RyanCavanaugh, I've started to run the task to cherry-pick this into |
|
Hey @RyanCavanaugh, I've opened #39601 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Jul 14, 2020
Component commits: c8d5b98 Load ETW module from a specified path
RyanCavanaugh
approved these changes
Jul 14, 2020
|
@typescript-bot cherry-pick this to release-3.9 |
|
Heya @RyanCavanaugh, I've started to run the task to cherry-pick this into |
|
Hey @RyanCavanaugh, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.9 manually. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Jul 14, 2020
Component commits: c8d5b98 Load ETW module from a specified path
RyanCavanaugh
pushed a commit
that referenced
this pull request
Jul 14, 2020
Component commits: c8d5b98 Load ETW module from a specified path Co-authored-by: Michael Crane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not rely on the default module resolution algorithm to load the optional typescript-etw module. Load it from the node_modules path that is local to the running server. This is where it is shipped with the Windows TypeScript SDK.
Also allow the path to be specified with the TS_ETW_MODULE_PATH environment variable. This will enable new use cases, e.g. VS Code.