Skip to content

Conversation

ShuiRuTian
Copy link
Contributor

@ShuiRuTian ShuiRuTian commented Jul 7, 2020

Fixes #39027

@ShuiRuTian
Copy link
Contributor Author

Friendly ping ~ @rbuckton

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Jul 21, 2020
@orta orta self-assigned this Jul 21, 2020
@orta
Copy link
Contributor

orta commented Jul 21, 2020

So, I chatted with Ryan about this and we think it's better to be doing this, so I'm gonna try run it against everything we've got - but we don't think there's going to be too many test cases which will get hit. Given our real-world test suites will all probably be using ascii everywhere.

@typescript-bot test this
@typescript-bot run dt
@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 21, 2020

Heya @orta, I've started to run the extended test suite on this PR at 9cc9756. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 21, 2020

Heya @orta, I've started to run the parallelized Definitely Typed test suite on this PR at 9cc9756. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 21, 2020

Heya @orta, I've started to run the parallelized community code test suite on this PR at 9cc9756. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@orta
Copy link
Contributor

orta commented Jul 22, 2020

OK, looked through all these results - nothing seems to stand out to me as being caused by the unescaped chars. At this point we can only be 100% certain when the RC drops (or folks using nightly hit something) but I'm reasonably confident.

I'm going to merge, thanks @ShuiRuTian 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a list of escaped character codes is displayed instead of part of the path
4 participants