Skip to content

[release-3.9] Add mising semicolon to '__exportStar'. #38509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/compiler/transformers/module/module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1887,7 +1887,7 @@ var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (
text: `
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}`
};`
};

function createExportStarHelper(context: TransformationContext, module: Expression) {
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/ambientShorthand_reExport.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
exports.__esModule = true;
__exportStar(require("jquery"), exports);
//// [reExportUser.js]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
exports.__esModule = true;
__exportStar(require("./thingB"), exports);
//// [index.js]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
exports.__esModule = true;
__exportStar(require("@emotion/core"), exports);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
Object.defineProperty(exports, "__esModule", { value: true });
__exportStar(require("./keys"), exports);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
Object.defineProperty(exports, "__esModule", { value: true });
__exportStar(require("./keys"), exports);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
Object.defineProperty(exports, "__esModule", { value: true });
__exportStar(require("./keys"), exports);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
exports.__esModule = true;
__exportStar(require("./b"), exports);
__exportStar(require("./c"), exports);
2 changes: 1 addition & 1 deletion tests/baselines/reference/es6ExportAllInEs5.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
Object.defineProperty(exports, "__esModule", { value: true });
__exportStar(require("./server"), exports);

Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/es6ExportEqualsInterop.js
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
exports.__esModule = true;
var z2 = require("variable");
var z3 = require("interface-variable");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ var __importStar = (this && this.__importStar) || function (mod) {
};
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
exports.__esModule = true;
var fs = __importStar(require("./fs"));
fs;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ var __importStar = (this && this.__importStar) || function (mod) {
};
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
Object.defineProperty(exports, "__esModule", { value: true });
var fs = __importStar(require("./fs"));
fs;
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/exportNamespace1.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
exports.__esModule = true;
__exportStar(require("./b"), exports);
//// [d.js]
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/exportStar-amd.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
define(["require", "exports", "./t1", "./t2", "./t3"], function (require, exports, t1_1, t2_1, t3_1) {
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/exportStar.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
Object.defineProperty(exports, "__esModule", { value: true });
__exportStar(require("./t1"), exports);
__exportStar(require("./t2"), exports);
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/exportStarForValues.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
define(["require", "exports", "file1"], function (require, exports, file1_1) {
"use strict";
exports.__esModule = true;
Expand Down
4 changes: 2 additions & 2 deletions tests/baselines/reference/exportStarForValues2.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
define(["require", "exports", "file1"], function (require, exports, file1_1) {
"use strict";
exports.__esModule = true;
Expand All @@ -43,7 +43,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
define(["require", "exports", "file2"], function (require, exports, file2_1) {
"use strict";
exports.__esModule = true;
Expand Down
8 changes: 4 additions & 4 deletions tests/baselines/reference/exportStarForValues3.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
define(["require", "exports", "file1"], function (require, exports, file1_1) {
"use strict";
exports.__esModule = true;
Expand All @@ -55,7 +55,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
define(["require", "exports", "file1"], function (require, exports, file1_1) {
"use strict";
exports.__esModule = true;
Expand All @@ -72,7 +72,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
define(["require", "exports", "file2", "file3"], function (require, exports, file2_1, file3_1) {
"use strict";
exports.__esModule = true;
Expand All @@ -90,7 +90,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
define(["require", "exports", "file4"], function (require, exports, file4_1) {
"use strict";
exports.__esModule = true;
Expand Down
4 changes: 2 additions & 2 deletions tests/baselines/reference/exportStarForValues4.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
define(["require", "exports", "file2"], function (require, exports, file2_1) {
"use strict";
exports.__esModule = true;
Expand All @@ -47,7 +47,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
define(["require", "exports", "file1", "file3"], function (require, exports, file1_1, file3_1) {
"use strict";
exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/exportStarForValues5.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
define(["require", "exports", "file1"], function (require, exports, file1_1) {
"use strict";
exports.__esModule = true;
Expand Down
4 changes: 2 additions & 2 deletions tests/baselines/reference/exportStarForValues7.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
define(["require", "exports", "file1"], function (require, exports, file1_1) {
"use strict";
exports.__esModule = true;
Expand All @@ -44,7 +44,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
define(["require", "exports", "file2"], function (require, exports, file2_1) {
"use strict";
exports.__esModule = true;
Expand Down
8 changes: 4 additions & 4 deletions tests/baselines/reference/exportStarForValues8.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
define(["require", "exports", "file1"], function (require, exports, file1_1) {
"use strict";
exports.__esModule = true;
Expand All @@ -56,7 +56,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
define(["require", "exports", "file1"], function (require, exports, file1_1) {
"use strict";
exports.__esModule = true;
Expand All @@ -74,7 +74,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
define(["require", "exports", "file2", "file3"], function (require, exports, file2_1, file3_1) {
"use strict";
exports.__esModule = true;
Expand All @@ -93,7 +93,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
define(["require", "exports", "file4"], function (require, exports, file4_1) {
"use strict";
exports.__esModule = true;
Expand Down
4 changes: 2 additions & 2 deletions tests/baselines/reference/exportStarForValues9.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
define(["require", "exports", "file2"], function (require, exports, file2_1) {
"use strict";
exports.__esModule = true;
Expand All @@ -48,7 +48,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
define(["require", "exports", "file1", "file3"], function (require, exports, file1_1, file3_1) {
"use strict";
exports.__esModule = true;
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/exportStarFromEmptyModule.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
Object.defineProperty(exports, "__esModule", { value: true });
exports.A = void 0;
__exportStar(require("./exportStarFromEmptyModule_module2"), exports);
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/exportStarNotElided.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
exports.__esModule = true;
__exportStar(require("./register"), exports);
__exportStar(require("./data1"), exports);
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/inlineJsxFactoryDeclarations.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
exports.__esModule = true;
/** @jsx dom */
var renderer_1 = require("./renderer");
Expand Down
4 changes: 2 additions & 2 deletions tests/baselines/reference/jsDeclarationsExportForms.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
Object.defineProperty(exports, "__esModule", { value: true });
__exportStar(require("./cls"), exports);
//// [bar2.js]
Expand All @@ -99,7 +99,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
Object.defineProperty(exports, "__esModule", { value: true });
__exportStar(require("./func"), exports);
__exportStar(require("./cls"), exports);
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/jsDeclarationsExportFormsErr.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
Object.defineProperty(exports, "__esModule", { value: true });
__exportStar(require("./cls"), exports);
//// [includeAll.js]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
exports.__esModule = true;
__exportStar(require("./file"), exports);
//// [augment.js]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
exports.__esModule = true;
__exportStar(require("./file"), exports);
//// [augment.js]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
exports.__esModule = true;
__exportStar(require("./file"), exports);
//// [augment.js]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
exports.__esModule = true;
__exportStar(require("./file"), exports);
//// [augment.js]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
}));
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !exports.hasOwnProperty(p)) __createBinding(exports, m, p);
}
};
exports.__esModule = true;
__exportStar(require("./account"), exports);
//// [index.js]
Expand Down
Loading