Skip to content

Delay pulling on signature contextual type until absolutely needed #37851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2020
Merged

Delay pulling on signature contextual type until absolutely needed #37851

merged 2 commits into from
Apr 21, 2020

Conversation

weswigham
Copy link
Member

@weswigham weswigham commented Apr 9, 2020 •
edited
Loading

Fixes #37600 (the remaining bits).

amcasey
amcasey reviewed Apr 9, 2020
View reviewed changes
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this delays the call and I can see how that might prevent a circularity, but that's the limit of my understanding. With that caveat, LGTM.

@weswigham weswigham merged commit a72e49e into microsoft:master Apr 21, 2020
@weswigham weswigham deleted the defer-return-type-contextual-signature-fetching branch April 21, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amcasey amcasey amcasey left review comments

@rbuckton rbuckton Awaiting requested review from rbuckton

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees

@weswigham weswigham

Labels
Author: Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New error: Excessive stack depth comparing types
3 participants
@weswigham @amcasey @typescript-bot