Fix rename for type symbols imported as a different name #37745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbranch
commented
Apr 2, 2020
Comment on lines
+95
to
+99
| else if (node.parent.kind === SyntaxKind.ExportAssignment | ||
| || node.parent.kind === SyntaxKind.ExternalModuleReference | ||
| || node.parent.kind === SyntaxKind.ImportSpecifier | ||
| || node.parent.kind === SyntaxKind.ImportClause | ||
| || isImportEqualsDeclaration(node.parent) && node === node.parent.name) { |
There was a problem hiding this comment.
The rename was bailing because it was calling getMeaningFromLocation on the import specifier’s identifier, and it was making it all the way to the bottom of the function, returning SemanticMeaning.Value. Seems like identifier serving as an import alias should be SemanticMeaning.All.
weswigham
approved these changes
Apr 2, 2020
sheetalkamat
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37188