Allow Source Mapping inside destructuring assignment #37298
Conversation
sandersn
added
the
For Milestone Bug
src/harness/harnessIO.ts
Outdated
| @@ -847,12 +847,28 @@ namespace Harness { | |||
| result.maps.forEach(sourceMap => { | |||
| if (sourceMapCode) sourceMapCode += "\r\n"; | |||
| sourceMapCode += fileOutput(sourceMap, harnessSettings); | |||
| if (!options.inlineSourceMap) { | |||
There was a problem hiding this comment.
If this is anyways going to be part of json file, canyou instead move emitting .map files into jsEmit baselines.. (we reduce number of files plus its easier to look at as well and get read of sourceMap.baseline.txt?)
There was a problem hiding this comment.
Cool. These changes got merged in #37111 - but I'm open to changing how it works!
Just to make sure I get the idea: This would be editingdoJsEmitBaseline to also include the sourcemap and link to the sourcemap file at the bottom of the emitted JS files as another section? (then I delete all the sourcemap files from test suite)
|
👋 - I've updated this PR to just be the changes rebased on master. There's still a lot of testfile changes (reading them, they seem to fit - anywhere where we had a destructured object now has a lot more sourcemap nodes ) |
Fixes #30364
also includes #37111 - but I can rebase that out (this just keeps all the baseline changes in on one merged commit instead of two saving on some history/disk space)