Skip to content

Adds a preview link to the baseline emits for sourcemaps #37111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2020

Conversation

orta
Copy link
Contributor

@orta orta commented Feb 28, 2020

Adds a preview link after every sourcemap in the baselines, this was like the least I could do to get some kind of visualization for the output of baselines

@orta orta force-pushed the emit_sourcemap_preview branch from d7b2a5d to 5062976 Compare February 28, 2020 20:37
@orta
Copy link
Contributor Author

orta commented Feb 28, 2020

baselines come at you fast

Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 🆒. I’ve never touched our source map stuff (or in fact, any source map stuff ever) so I have basically no knowledge or stake in this, but it seems like a clear win to me.

@sandersn
Copy link
Member

@orta this is ready to go, right?

@orta
Copy link
Contributor Author

orta commented Mar 26, 2020

Yeah, let's do it - if it can survive a month of no conflicts, I think it's a fine call

@orta orta merged commit 6afd5c9 into microsoft:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants