Skip to content

Fix crash on aliased, exported @enum tag in jsdoc #36996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Fix crash on aliased, exported @enum tag in jsdoc #36996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/compiler/binder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2113,7 +2113,9 @@ namespace ts {
container = (declName.parent.expression as PropertyAccessExpression).name;
break;
case AssignmentDeclarationKind.Property:
container = isPropertyAccessExpression(declName.parent.expression) ? declName.parent.expression.name : declName.parent.expression;
container = isExportsOrModuleExportsOrAlias(file, declName.parent.expression) ? file
: isPropertyAccessExpression(declName.parent.expression) ? declName.parent.expression.name
: declName.parent.expression;
break;
case AssignmentDeclarationKind.None:
return Debug.fail("Shouldn't have detected typedef or enum on non-assignment declaration");
Expand Down
18 changes: 18 additions & 0 deletions tests/baselines/reference/exportedAliasedEnumTag.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
=== tests/cases/conformance/jsdoc/exportedAliasedEnumTag.js ===
var middlewarify = module.exports = {};
>middlewarify : Symbol(middlewarify, Decl(exportedAliasedEnumTag.js, 0, 3))
>module.exports : Symbol("tests/cases/conformance/jsdoc/exportedAliasedEnumTag", Decl(exportedAliasedEnumTag.js, 0, 0))
>module : Symbol(module, Decl(exportedAliasedEnumTag.js, 0, 18))
>exports : Symbol("tests/cases/conformance/jsdoc/exportedAliasedEnumTag", Decl(exportedAliasedEnumTag.js, 0, 0))

/** @enum */
middlewarify.Type = {
>middlewarify.Type : Symbol(Type, Decl(exportedAliasedEnumTag.js, 0, 39), Decl(exportedAliasedEnumTag.js, 3, 13), Decl(exportedAliasedEnumTag.js, 2, 4))
>middlewarify : Symbol(middlewarify, Decl(exportedAliasedEnumTag.js, 0, 3))
>Type : Symbol(Type, Decl(exportedAliasedEnumTag.js, 0, 39), Decl(exportedAliasedEnumTag.js, 3, 13), Decl(exportedAliasedEnumTag.js, 2, 4))

BEFORE: 'before'
>BEFORE : Symbol(BEFORE, Decl(exportedAliasedEnumTag.js, 3, 21))

};

23 changes: 23 additions & 0 deletions tests/baselines/reference/exportedAliasedEnumTag.types
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
=== tests/cases/conformance/jsdoc/exportedAliasedEnumTag.js ===
var middlewarify = module.exports = {};
>middlewarify : typeof import("tests/cases/conformance/jsdoc/exportedAliasedEnumTag")
>module.exports = {} : typeof import("tests/cases/conformance/jsdoc/exportedAliasedEnumTag")
>module.exports : typeof import("tests/cases/conformance/jsdoc/exportedAliasedEnumTag")
>module : { "\"tests/cases/conformance/jsdoc/exportedAliasedEnumTag\"": typeof import("tests/cases/conformance/jsdoc/exportedAliasedEnumTag"); }
>exports : typeof import("tests/cases/conformance/jsdoc/exportedAliasedEnumTag")
>{} : {}

/** @enum */
middlewarify.Type = {
>middlewarify.Type = { BEFORE: 'before'} : { BEFORE: string; }
>middlewarify.Type : { BEFORE: string; }
>middlewarify : typeof import("tests/cases/conformance/jsdoc/exportedAliasedEnumTag")
>Type : { BEFORE: string; }
>{ BEFORE: 'before'} : { BEFORE: string; }

BEFORE: 'before'
>BEFORE : string
>'before' : "before"

};

9 changes: 9 additions & 0 deletions tests/cases/conformance/jsdoc/exportedAliasedEnumTag.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// @noemit: true
// @allowjs: true
// @filename: exportedAliasedEnumTag.js
var middlewarify = module.exports = {};

/** @enum */
middlewarify.Type = {
BEFORE: 'before'
};