Skip to content

Update scripts for octokit 17 #36915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2020
Merged

Update scripts for octokit 17 #36915

merged 2 commits into from
Feb 21, 2020

Conversation

sandersn
Copy link
Member

Also put playwright in alphabetical order, npm seems to like that.

Also put playwright in alphabetical order, npm seems to like that.
@sandersn
Copy link
Member Author

@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 21, 2020

Heya @sandersn, I've started to run the parallelized community code test suite on this PR at 4947b31. You can monitor the build here. It should now contribute to this PR's status checks.

@sandersn sandersn mentioned this pull request Feb 21, 2020
3 tasks
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat

@sandersn
Copy link
Member Author

sandersn commented Feb 21, 2020

TypeError: gh.authenticate is not a function.

Back to the drawing board.

@sandersn
Copy link
Member Author

Octokit's index.d.ts:

export declare const Octokit: (new (...args: any[]) => {
    [x: string]: any;
}) & {
    new (...args: any[]): {
        [x: string]: any;
    };
    plugins: any[];
} & typeof Core & import("@octokit/core/dist-types/types").Constructor<void> & import("@octokit/core/dist-types/types").Constructor<{
    paginate: import("@octokit/plugin-paginate-rest").PaginateInterface;
} & import("@octokit/plugin-rest-endpoint-methods/dist-types/generated/types").RestEndpointMethods>;

questionblock

@sandersn
Copy link
Member Author

@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 21, 2020

Heya @sandersn, I've started to run the parallelized community code test suite on this PR at 077aedc. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@sandersn
Copy link
Member Author

Thanks @typescript-bot!

@sandersn sandersn merged commit a5061ef into master Feb 21, 2020
@jakebailey jakebailey deleted the update-octokit-rest branch November 7, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants