Skip to content

Fix crash when trying to import a non-exported type #36619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/compiler/checker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2530,8 +2530,8 @@ namespace ts {
: error(name, Diagnostics.Module_0_declares_1_locally_but_it_is_not_exported, moduleName, declarationName);

addRelatedInfo(diagnostic,
createDiagnosticForNode(localSymbol.valueDeclaration, Diagnostics._0_is_declared_here, declarationName)
);
...map(localSymbol.declarations, (decl, index) =>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There could be more than one declaration, but exporting any of them will fix the error, so 🤷‍♂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also report an error on all of them which might feel cleaner and work well too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably just avoid the ...map and use forEach but whatever you'd prefer.

createDiagnosticForNode(decl, index === 0 ? Diagnostics._0_is_declared_here : Diagnostics.and_here, declarationName)));
}
else {
error(name, Diagnostics.Module_0_has_no_exported_member_1, moduleName, declarationName);
Expand Down
13 changes: 13 additions & 0 deletions tests/baselines/reference/importNonExportedMember2.errors.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
tests/cases/compiler/b.ts(1,10): error TS2459: Module '"./a"' declares 'Foo' locally, but it is not exported.


==== tests/cases/compiler/a.ts (0 errors) ====
export {}
interface Foo {}

==== tests/cases/compiler/b.ts (1 errors) ====
import { Foo } from './a';
~~~
!!! error TS2459: Module '"./a"' declares 'Foo' locally, but it is not exported.
!!! related TS2728 tests/cases/compiler/a.ts:2:11: 'Foo' is declared here.

16 changes: 16 additions & 0 deletions tests/baselines/reference/importNonExportedMember2.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
//// [tests/cases/compiler/importNonExportedMember2.ts] ////

//// [a.ts]
export {}
interface Foo {}

//// [b.ts]
import { Foo } from './a';


//// [a.js]
"use strict";
exports.__esModule = true;
//// [b.js]
"use strict";
exports.__esModule = true;
9 changes: 9 additions & 0 deletions tests/baselines/reference/importNonExportedMember2.symbols
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
=== tests/cases/compiler/a.ts ===
export {}
interface Foo {}
>Foo : Symbol(Foo, Decl(a.ts, 0, 9))

=== tests/cases/compiler/b.ts ===
import { Foo } from './a';
>Foo : Symbol(Foo, Decl(b.ts, 0, 8))

8 changes: 8 additions & 0 deletions tests/baselines/reference/importNonExportedMember2.types
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
=== tests/cases/compiler/a.ts ===
export {}
No type information for this code.interface Foo {}
No type information for this code.
No type information for this code.=== tests/cases/compiler/b.ts ===
import { Foo } from './a';
>Foo : any

17 changes: 17 additions & 0 deletions tests/baselines/reference/importNonExportedMember3.errors.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
tests/cases/compiler/b.ts(1,10): error TS2459: Module '"./a"' declares 'Foo' locally, but it is not exported.


==== tests/cases/compiler/a.ts (0 errors) ====
export {}
interface Foo {}
interface Foo {}
namespace Foo {}

==== tests/cases/compiler/b.ts (1 errors) ====
import { Foo } from './a';
~~~
!!! error TS2459: Module '"./a"' declares 'Foo' locally, but it is not exported.
!!! related TS2728 tests/cases/compiler/a.ts:2:11: 'Foo' is declared here.
!!! related TS6204 tests/cases/compiler/a.ts:3:11: and here.
!!! related TS6204 tests/cases/compiler/a.ts:4:11: and here.

18 changes: 18 additions & 0 deletions tests/baselines/reference/importNonExportedMember3.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
//// [tests/cases/compiler/importNonExportedMember3.ts] ////

//// [a.ts]
export {}
interface Foo {}
interface Foo {}
namespace Foo {}

//// [b.ts]
import { Foo } from './a';


//// [a.js]
"use strict";
exports.__esModule = true;
//// [b.js]
"use strict";
exports.__esModule = true;
15 changes: 15 additions & 0 deletions tests/baselines/reference/importNonExportedMember3.symbols
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
=== tests/cases/compiler/a.ts ===
export {}
interface Foo {}
>Foo : Symbol(Foo, Decl(a.ts, 0, 9), Decl(a.ts, 1, 16), Decl(a.ts, 2, 16))

interface Foo {}
>Foo : Symbol(Foo, Decl(a.ts, 0, 9), Decl(a.ts, 1, 16), Decl(a.ts, 2, 16))

namespace Foo {}
>Foo : Symbol(Foo, Decl(a.ts, 0, 9), Decl(a.ts, 1, 16), Decl(a.ts, 2, 16))

=== tests/cases/compiler/b.ts ===
import { Foo } from './a';
>Foo : Symbol(Foo, Decl(b.ts, 0, 8))

10 changes: 10 additions & 0 deletions tests/baselines/reference/importNonExportedMember3.types
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
=== tests/cases/compiler/a.ts ===
export {}
No type information for this code.interface Foo {}
No type information for this code.interface Foo {}
No type information for this code.namespace Foo {}
No type information for this code.
No type information for this code.=== tests/cases/compiler/b.ts ===
import { Foo } from './a';
>Foo : any

6 changes: 6 additions & 0 deletions tests/cases/compiler/importNonExportedMember2.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// @Filename: a.ts
export {}
interface Foo {}

// @Filename: b.ts
import { Foo } from './a';
8 changes: 8 additions & 0 deletions tests/cases/compiler/importNonExportedMember3.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
// @Filename: a.ts
export {}
interface Foo {}
interface Foo {}
namespace Foo {}

// @Filename: b.ts
import { Foo } from './a';