Skip to content

Conversation

rbuckton
Copy link
Contributor

@rbuckton rbuckton commented Jan 31, 2020

This fixes two issues with call hierarchy:

  • When preparing a call hierarchy item we were incorrectly using the script info for the file at the current cursor position when resolving line/character for item's declaration, which could be in another file.
  • When resolving incoming calls, we were incorrectly using the script info for the current call hierarchy item rather than the script info for the file containing the incoming declaration.

Note that the current behavior for outgoing calls is correct (it uses the script info for the current call hierarchy item).

Fixes #36509
Fixes #36512

@rbuckton rbuckton merged commit 9a357c1 into master Jan 31, 2020
@rbuckton rbuckton deleted the fix36509 branch January 31, 2020 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad call hierarchy highlights TypeScript Call Hierarchy view fails to find callers for registerCommand in extension template
3 participants