keyofStringsOnly affects diagnostics and emit #36291
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajafff
commented
Jan 18, 2020
| @@ -974,6 +974,8 @@ namespace ts { | |||
| { | |||
| name: "keyofStringsOnly", | |||
| type: "boolean", | |||
| affectsSemanticDiagnostics: true, | |||
| affectsEmit: true, | |||
There was a problem hiding this comment.
Actually this flag doesn't affect JS emit. It only affects declaration emit. In fact anything that changes type inference (like strictNullChecks, noImplicitAny) affects semantic diagnostics and declaration emit.
Is it worth adding a new flag affectsTypeInference that implicitly contains affectsSemanticDiagnostics and affectsEmit only for declaration files?
|
@ajafff what bug does this PR fix? |
sandersn
added
For Uncommitted Bug
|
This PR hasn't seen any activity for quite a while, so I'm going to close it to keep the number of open PRs manageable. Feel free to open a fresh PR or continue the discussion here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #36290 and #36001
There are more to come.