Use watch invoked with node_modules/.staging as watch for refreshing complete node_modules, so that npm install is reflected correctly
#36039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g complete node_modules, so that npm install is reflected correctly Fixes #35966
sheetalkamat
requested review from
weswigham,
andrewbranch,
amcasey,
elibarzilay,
gabritto,
rbuckton,
RyanCavanaugh,
sandersn and
orta
andrewbranch
approved these changes
Jan 9, 2020
Kingwl
pushed a commit
to Kingwl/TypeScript
that referenced
this pull request
Mar 4, 2020
…g complete node_modules, so that npm install is reflected correctly (microsoft#36039) * Add test that demonstrates npm install watch behaviour some times * Use watch invoked with `node_modules/.staging` as watch for refreshing complete node_modules, so that npm install is reflected correctly Fixes microsoft#35966
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases npm install triggers watches with folder additions to
.stagingfolder which we ignore.Afterwards it moves everything with renames from
.stagingtonode_modulesfolder. Many times there is individual watches invoked with those folders which we handle correctly but in some cases it just triggers watch withnode_modules/.stagingwhich again was ignored. Now when the watch invoked is.staging(and not sub folder/file in it) we refresh everything innode_modulesinstead to invalidate resolutions and files accordingly.Fixes #35966