Move executeCommandLine.ts into its own project #35595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
approved these changes
Dec 10, 2019
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Seems fine, although I've spent little time thinking about our project structure.
Member
Author
|
L |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It being in two projects (
tscandtestRunner) simultaneously is probably already causing interesting things with our current build, and when transformed, it ends up getting emitted multiple times (each time from a different program, checked in a different way, against different interfaces). This causes some stuff to go poorly (namely namespace references get mangled).So this fixes that by moving it into its own project, on which both
tscandtestRunnerdepend (it, in turn, depends oncompiler, liketsc). This is much more in-line with how project references are supposed to be used for a situation like this.