Skip to content

Move executeCommandLine.ts into its own project #35595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2019

Conversation

weswigham
Copy link
Member

@weswigham weswigham commented Dec 9, 2019

It being in two projects (tsc and testRunner) simultaneously is probably already causing interesting things with our current build, and when transformed, it ends up getting emitted multiple times (each time from a different program, checked in a different way, against different interfaces). This causes some stuff to go poorly (namely namespace references get mangled).

So this fixes that by moving it into its own project, on which both tsc and testRunner depend (it, in turn, depends on compiler, like tsc). This is much more in-line with how project references are supposed to be used for a situation like this.

Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, although I've spent little time thinking about our project structure.

@weswigham
Copy link
Member Author

L
A
Y
E
R
S

@weswigham weswigham merged commit 6936ac2 into microsoft:master Dec 10, 2019
@weswigham weswigham deleted the move-executecommandline branch December 10, 2019 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants