Skip to content

Fix check for get/set recommendation #34885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 19, 2019
Merged

Fix check for get/set recommendation #34885

merged 11 commits into from
Nov 19, 2019

Conversation

DanielRosenwasser
Copy link
Member

Fixes #34884

orta
orta approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

src/compiler/utilities.ts
return tryGetPropertyAccessOrIdentifierToString(expr.expression) + "." + expr.name;
const baseStr = tryGetPropertyAccessOrIdentifierToString(expr.expression);
if (baseStr !== undefined) {
return baseStr + "." + expr.name;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 👍

@DanielRosenwasser DanielRosenwasser merged commit b50b9e0 into master Nov 19, 2019
@DanielRosenwasser DanielRosenwasser deleted the fixCheckForGetSetRecommendation branch November 19, 2019 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@orta orta orta approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Did you mean 'get'/'set'?" errors have issues
2 participants
@DanielRosenwasser @orta