Skip to content

Add support for jsdoc properties with hyphen #32631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2019
Merged

Add support for jsdoc properties with hyphen #32631

merged 2 commits into from
Aug 20, 2019

Conversation

fuafa
Copy link
Contributor

@fuafa fuafa commented Jul 31, 2019

Fixes #14395

@orta
Copy link
Contributor

orta commented Aug 7, 2019

This looks good to me, alas there are merge conflicts from f333684 - it might be possible that this also fixed the issue too

@fuafa
Copy link
Contributor Author

fuafa commented Aug 13, 2019

Hi @orta , thank you for reviewing, I think the IdentifierPart still not include the hyphen token after that commit. However my solution has some limitations which make all hyphened-indentifier in js-doc valid, other than those as object properties. So if you think it is not good, I will close it.

@sandersn sandersn merged commit 24201cf into microsoft:master Aug 20, 2019
@fuafa fuafa deleted the hyphen-properties branch August 21, 2019 16:24
timsuchanek pushed a commit to timsuchanek/TypeScript that referenced this pull request Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSDoc Property Name with Dash Not Recognized
3 participants