When the exported symbol is merged symbol from declaration use that name #32531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame to verify quality Fixes #27880
sheetalkamat
requested review from
orta,
sandersn,
weswigham,
andrewbranch,
rbuckton and
RyanCavanaugh
andrewbranch
approved these changes
Jul 23, 2019
weswigham
reviewed
Jul 23, 2019
| return { symbolForMeaning: defaultExport, name: moduleSymbolToValidIdentifier(moduleSymbol, compilerOptions.target!) }; | ||
|
|
||
| if (defaultExport.escapedName !== InternalSymbolName.Default && | ||
| defaultExport.escapedName !== InternalSymbolName.ExportEquals) { |
There was a problem hiding this comment.
I'd also check that that name isIdentifierText, just in case the name comes from, say, a jsdoc typedef or a js property assignment where the original declaration's name wasn't an identifier.
There was a problem hiding this comment.
@weswigham we don't need to check that since this is the name just to compare the defaultExportSymbol ==== symbol we are looking for and that symbol's name does default to symbol.name if its not export= or default. The actual text to be displayed is calculated later.
weswigham
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27880