Skip to content

Fix _superIndex emit when super access captured in async arrow #30479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2019
Merged

Fix _superIndex emit when super access captured in async arrow #30479

merged 1 commit into from
Mar 19, 2019

Conversation

rbuckton
Copy link
Contributor

@rbuckton rbuckton commented Mar 19, 2019 •
edited
Loading

We were incorrectly resetting hasSuperElementAccess and capturedSuperProperties when transforming the body of an async arrow function.

NOTE: This is the same fix as #30491 except that this targets release-3.4

Fixes #30066

@rbuckton rbuckton mentioned this pull request Mar 19, 2019
Merged
@rbuckton rbuckton merged commit 972eaf6 into release-3.4 Mar 19, 2019
@rbuckton rbuckton deleted the fix30066 branch March 19, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

@sandersn sandersn Awaiting requested review from sandersn

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbuckton @weswigham