Allow union signatures to merge when they have differing argument counts #28604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
reviewed
Nov 19, 2018
| @@ -118,15 +114,13 @@ tests/cases/conformance/types/union/unionTypeCallSignatures.ts(73,12): error TS2 | |||
| var unionWithOptionalParameter3: { (a: string, b?: number): string; } | { (a: string): number; }; | |||
| strOrNum = unionWithOptionalParameter3('hello'); | |||
| strOrNum = unionWithOptionalParameter3('hello', 10); // error no call signature | |||
There was a problem hiding this comment.
remove error comment, and edit the next one to say something like // bad argument type
sandersn
approved these changes
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically when the target has the same or more arguments than the source, this way the signature with a greater number of more specific arguments becomes the backing signature for a union signature.
Fixes #28575