Blocks with locals should be added to the container chain. #2856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etect name collisions in them.
| @@ -352,7 +352,7 @@ module ts { | |||
| export function isLineBreak(ch: number): boolean { | |||
| // ES5 7.3: | |||
| // The ECMAScript line terminator characters are listed in Table 3. | |||
| // Table 3 � Line Terminator Characters | |||
| // Table 3: Line Terminator Characters | |||
There was a problem hiding this comment.
There was an errant extended character in the file, breaking cscript.
|
🐹 |
CyrusNajmabadi
added a commit
that referenced
this pull request
Apr 22, 2015
Blocks with locals should be added to the container chain.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By doing this we can accurately handle name collisions with block scoped locals.
Fixes #2852