Skip to content

Make JSON.parse return a JSON value instead of any #28416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make JSON.parse return a JSON value instead of any #28416

wants to merge 1 commit into from

Conversation

dalen
Copy link

@dalen dalen commented Nov 8, 2018 •
edited
Loading

This makes type checking of things hangling JSON responses much more accurate and useful.

@dalen dalen force-pushed the patch-1 branch 3 times, most recently from 21e8783 to 83a8962 Compare November 8, 2018 20:16
@dalen dalen changed the title Make JSON.parse return unknown instead of any Make JSON.parse return a JSON value instead of any Nov 8, 2018
@dalen
Make JSON.parse return a JSONValue instead of any
205a276 
This makes type checking of things hangling JSON responses much more accurate and useful.
@j-oliveras
Copy link
Contributor

j-oliveras commented Nov 8, 2018 •
edited
Loading

Already discussed and rejected as Working as intended: #26993 and #26994.

@dalen dalen closed this Nov 9, 2018
@j-oliveras j-oliveras mentioned this pull request Mar 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dalen @j-oliveras