Fix incorrectly passed event name for ProjectLoadingFinish event #28266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Oct 31, 2018
|
|
||
| function getEvents() { | ||
| const outputEventRegex = /Content\-Length: [\d]+\r\n\r\n/; | ||
| return filter( |
There was a problem hiding this comment.
I usually prefer mapDefined over filter(map(*)), so you don't need a cast at the end and avoid an extra array.
| } | ||
| } | ||
| }); | ||
|
|
||
| return { session, events }; | ||
| } | ||
|
|
||
| function createSessionWithDefaultEventHandler<T extends protocol.AnyEvent>(host: TestServerHost, eventName: T["event"], opts: Partial<server.SessionOptions> = {}, ...eventNames: T["event"][]) { |
There was a problem hiding this comment.
If we want the event names to be a rest parameter, we should move eventName to the end and combine it with that. And if we want it to be the second parameter, we could take string | ReadonlyArray<string> there.
ghost
approved these changes
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.