Remove 'verify.fileAfterCodeFix', use 'verify.codeFix' #28110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
sandersn
reviewed
Oct 24, 2018
| verify.fileAfterCodeFix( | ||
| verify.codeFix({ | ||
| description: "Infer parameter types from usage", | ||
| index: 2, |
Member
There was a problem hiding this comment.
If you don't know the index, how can I figure out the index? With fileAfterCodeFix, leaving off the last two arguments prints out a list of provided code fixes.
Author
There was a problem hiding this comment.
verify.codeFix does the same thing -- using the same (duplicated) code.
sandersn
approved these changes
Oct 24, 2018
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
One usability question, although I think it's a good change overall.
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no reason to have two separate methods for testing the same thing, and
verify.codeFixstrictly tests more, since it tests the description and whitespace.